Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Division by zero in isWithinDeviationThreshold #127

Closed
CloudEllie opened this issue Apr 27, 2022 · 2 comments
Closed

Division by zero in isWithinDeviationThreshold #127

CloudEllie opened this issue Apr 27, 2022 · 2 comments
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value duplicate This issue or pull request already exists

Comments

@CloudEllie
Copy link
Contributor

Judge @jack-the-pug is upgrading the following issue from a QA report (issue #30 ) to Medium risk:

Division by zero in isWithinDeviationThreshold if a is zero. This only seems to be the case if the oracle would return 0 for CPI and in this case, something is wrong anyway. Should still handle this error more gracefully.
@CloudEllie CloudEllie added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value duplicate This issue or pull request already exists labels Apr 27, 2022
@CloudEllie
Copy link
Contributor Author

Duplicate of #58

@CloudEllie CloudEllie marked this as a duplicate of #58 Apr 27, 2022
@CloudEllie CloudEllie mentioned this issue Apr 27, 2022
Open
@jack-the-pug
Copy link
Collaborator

Confirmed! Thanks @CloudEllie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CloudEllie @jack-the-pug