Skip to content

Latest commit

 

History

History
40 lines (22 loc) · 1.76 KB

chrisdior4-Q.md

File metadata and controls

40 lines (22 loc) · 1.76 KB

L-01 Use the latest version of OpenZeppelin

To prevent any issues in the future (e.g. using solely hardhat to compile and deploy the contracts), upgrade the used OZ packages within the package.json to the latest versions.

Recommended Mitigation Steps:

Consider using the latest OZ packages (v4.7.3) within package.json.

==============================

N-01 MISSING ZERO ADDRESS CHECK FOR _l2Receiver

_l2Receiver is the account address that would receive minted ether

Recommended Mitigation Steps:

Consider adding a zero address check for _l2Receiver

=============================

N-02 Typos

There are a few typos in the contract's comments:

1.Stores the L1 address of the bridge and set .../.../decimls - decimals *

2.It is standard implementation of ERC20 Bridge that can be used as a refference - reference *

3.We are expecting to see the exect two bytecodes - exact *

4.@title Diamond Proxy Cotract (EIP-2535) - Contract *