In the EVM, there is no opcode for >= or <=. When using greater than or equal, two operations are performed: > and =. Using strict comparison operators hence saves gas
There are 9 instances of this issue:
File: /ethereum/contracts/zksync/DiamondProxy.sol
24: require(msg.data.length >= 4 || msg.data.length == 0, "Ut");https://github.com/code-423n4/2022-10-zksync/blob/main/ethereum/contracts/zksync/DiamondProxy.sol
File: /ethereum/contracts/zksync/facets/DiamondCut.sol
49: bool approvedBySecurityCouncil = s.diamondCutStorage.securityCouncilEmergencyApprovals >=
52: bool upgradeNoticePeriodPassed = block.timestamp >=File: /ethereum/contracts/zksync/facets/Executor.sol
50: bool timestampNotTooSmall = block.timestamp - COMMIT_TIMESTAMP_NOT_OLDER <= l2BlockTimestamp;
51: bool timestampNotTooBig = l2BlockTimestamp <= block.timestamp + COMMIT_TIMESTAMP_APPROXIMATION_DELTA;
216: require(s.totalBlocksExecuted <= s.totalBlocksVerified, "n"); // Can't execute blocks more then committed and proven currently.
268: require(currentTotalBlocksVerified <= s.totalBlocksCommitted, "q");File: /ethereum/contracts/zksync/facets/Mailbox.sol
56: require(_blockNumber <= s.totalBlocksExecuted, "xx");
124: require(_ergsLimit <= PRIORITY_TX_MAX_ERGS_LIMIT, "ui");There are 7 instances of this issue:
File: /ethereum/contracts/zksync/Storage.sol
17: struct DiamondCutStorage {https://github.com/code-423n4/2022-10-zksync/blob/main/ethereum/contracts/zksync/Storage.sol
File: /ethereum/contracts/zksync/interfaces/IExecutor.sol
15: struct StoredBlockInfo {
40: struct CommitBlockInfo {File: /ethereum/contracts/bridge/L1EthBridge.sol
33: address constant CONVENTIONAL_ETH_ADDRESS = address(0);
44: address public l2Bridge;https://github.com/code-423n4/2022-10-zksync/blob/main/ethereum/contracts/bridge/L1EthBridge.sol
File: /zksync/contracts/bridge/L2ETHBridge.sol
22: address public override l1Bridge;
28: address constant CONVENTIONAL_ETH_ADDRESS = address(0);https://github.com/code-423n4/2022-10-zksync/blob/main/zksync/contracts/bridge/L2ETHBridge.sol
There are 1 instances of this issue:
File: /ethereum/contracts/zksync/facets/DiamondCut.sol
29: s.diamondCutStorage.currentProposalId += 1;Marking a function as payable reduces gas cost since the compiler does not have to check whether a payment was provided or not. This change will save around 21 gas per function call.
There are 18 instances of this issue:
File: /ethereum/contracts/zksync/facets/DiamondCut.sol
22: function proposeDiamondCut(Diamond.FacetCut[] calldata _facetCuts, address _initAddress) external onlyGovernor {
35: function cancelDiamondCutProposal() external onlyGovernor {
46: function executeDiamondCutProposal(Diamond.DiamondCutData calldata _diamondCut) external onlyGovernor {
78: function emergencyFreezeDiamond() external onlyGovernor {
91: function unfreezeDiamond() external onlyGovernor {File: /ethereum/contracts/zksync/facets/Executor.sol
152: function commitBlocks(StoredBlockInfo memory _lastCommittedBlockData, CommitBlockInfo[] calldata _newBlocksData)
208: function executeBlocks(StoredBlockInfo[] calldata _blocksData) external nonReentrant onlyValidator {
221: function proveBlocks(
336: function revertBlocks(uint256 _newLastBlock) external nonReentrant onlyValidator {File: /ethereum/contracts/zksync/facets/Governance.sol
15: function setPendingGovernor(address _newPendingGovernor) external onlyGovernor {
45: function setValidator(address _validator, bool _active) external onlyGovernor {
54: function setL2BootloaderBytecodeHash(bytes32 _l2BootloaderBytecodeHash) external onlyGovernor {
69: function setL2DefaultAccountBytecodeHash(bytes32 _l2DefaultAccountBytecodeHash) external onlyGovernor {
84: function setPorterAvailability(bool _zkPorterIsAvailable) external onlyGovernor {File: /ethereum/contracts/common/AllowList.sol
57: function setPublicAccess(address _target, bool _enable) external onlyOwner {
94: ) external onlyOwner {
118: ) external onlyOwner {
140: function setPendingOwner(address _newPendingOwner) external onlyOwner {https://github.com/code-423n4/2022-10-zksync/blob/main/ethereum/contracts/common/AllowList.sol
When a function with a memory array is called externally, the abi.decode() step has to use a for-loop to copy each index of the calldata to the memory index. Each iteration of this for-loop costs at least 60 gas (i.e. 60 * <mem_array>.length). Using calldata directly, obliviates the need for such a loop in the contract code and runtime execution.
There are 5 instances of this issue:
File: /ethereum/contracts/zksync/facets/Mailbox.sol
89: function l2TransactionBaseCost(File: /ethereum/contracts/bridge/L1ERC20Bridge.sol
282: function l2TokenAddress(address _l1Token) public view returns (address) {File: /ethereum/contracts/bridge/L1EthBridge.sol
243: function l2TokenAddress(address) public pure returns (address) {https://github.com/code-423n4/2022-10-zksync/blob/main/ethereum/contracts/bridge/L1EthBridge.sol
File: /zksync/contracts/bridge/L2ETHBridge.sol
79: function l2TokenAddress(address) public pure returns (address) {
84: function l1TokenAddress(address) public pure override returns (address) {https://github.com/code-423n4/2022-10-zksync/blob/main/zksync/contracts/bridge/L2ETHBridge.sol
Instead of using && on single require check using two require checks can save gas
There are 2 instances of this issue:
File: /ethereum/contracts/common/AllowList.sol
97: callersLength == _targets.length &&
98: callersLength == _functionSigs.length &&https://github.com/code-423n4/2022-10-zksync/blob/main/ethereum/contracts/common/AllowList.sol
There are 106 instances of this issue:
File: /ethereum/contracts/zksync/libraries/Diamond.sol
100: require(selectors.length > 0, "B"); // no functions for diamond cut
126: require(_facet != address(0), "G"); // facet with zero address cannot be added
135: require(oldFacet.facetAddress == address(0), "J"); // facet for this selector already exists
150: require(_facet != address(0), "K"); // cannot replace facet with zero address
156: require(oldFacet.facetAddress != address(0), "L"); // it is impossible to replace the facet with zero address
170: require(_facet == address(0), "a1"); // facet address must be zero
176: require(oldFacet.facetAddress != address(0), "a2"); // Can't delete a non-existent facet
214: require(_isSelectorFreezable == ds.selectorToFacet[selector0].isFreezable, "J1");
279: require(_calldata.length == 0, "H"); // Non-empty calldata for zero address
283: require(success, "I"); // delegatecall failed
287: require(data.length == 32, "lp");
288: require(abi.decode(data, (bytes32)) == DIAMOND_INIT_SUCCESS_RETURN_VALUE, "lp1");File: /ethereum/contracts/zksync/libraries/Merkle.sol
23: require(pathLength > 0, "xc");
24: require(pathLength < 256, "bt");
25: require(_index < 2**pathLength, "pz");File: /ethereum/contracts/zksync/libraries/PriorityQueue.sol
64: require(!_queue.isEmpty(), "D"); // priority queue is empty
72: require(!_queue.isEmpty(), "s"); // priority queue is emptyFile: /ethereum/contracts/zksync/facets/Base.sol
16: require(msg.sender == s.governor, "1g"); // only by governor
22: require(s.validators[msg.sender], "1h"); // validator is not activehttps://github.com/code-423n4/2022-10-zksync/blob/main/ethereum/contracts/zksync/facets/Base.sol
File: /ethereum/contracts/zksync/facets/DiamondCut.sol
23: require(s.diamondCutStorage.proposedDiamondCutTimestamp == 0, "a3"); // proposal already exists
40: require(_resetProposal(), "g1"); // failed cancel diamond cut
55: require(approvedBySecurityCouncil || upgradeNoticePeriodPassed, "a6"); // notice period should expire
56: require(approvedBySecurityCouncil || !diamondStorage.isFrozen, "f3");
59: require(
65: require(_resetProposal(), "a5"); // failed reset proposal
80: require(!diamondStorage.isFrozen, "a9"); // diamond proxy is frozen already
94: require(diamondStorage.isFrozen, "a7"); // diamond proxy is not frozen
106: require(s.diamondCutStorage.securityCouncilMembers[msg.sender], "a9"); // not a security council member
108: require(s.diamondCutStorage.securityCouncilMemberLastApprovedProposalId[msg.sender] < currentProposalId, "ao"); // already approved this proposal
111: require(s.diamondCutStorage.proposedDiamondCutTimestamp != 0, "f0"); // there is no proposed diamond cut
112: require(s.diamondCutStorage.proposedDiamondCutHash == _diamondCutHash, "f1"); // proposed diamond cut do not match to the approvedFile: /ethereum/contracts/zksync/facets/Executor.sol
28: require(_newBlock.blockNumber == _previousBlock.blockNumber + 1, "f"); // only commit next block
39: require(_previousBlock.blockHash == previousBlockHash, "l");
41: require(expectedPriorityOperationsHash == _newBlock.priorityOperationsHash, "t");
43: require(expectedNumberOfLayer1Txs == _newBlock.numberOfLayer1Txs);
45: require(l2BlockTimestamp == _newBlock.timestamp);
52: require(timestampNotTooSmall, "h"); // New block timestamp is too small
53: require(timestampNotTooBig, "h1"); // New block timestamp is too big
57: require(
117: require(keccak256(l2Messages[currentMessage]) == hashedMessage, "k2");
129: require(!isSystemContextLogProcessed, "fx");
136: require(bytecodeHash == L2ContractHelper.hashL2Bytecode(factoryDeps[currentBytecode]), "k3");
142: require(currentBytecode == factoryDeps.length, "ym");
143: require(currentMessage == l2Messages.length, "pl");
145: require(isSystemContextLogProcessed, "by");
159: require(s.storedBlockHashes[s.totalBlocksCommitted] == _hashStoredBlockInfo(_lastCommittedBlockData), "i"); // incorrect previous block data
192: require(currentBlockNumber == s.totalBlocksExecuted + _executedBlockIdx + 1, "k"); // Execute blocks in order
193: require(
199: require(priorityOperationsHash == _storedBlock.priorityOperationsHash, "x"); // priority operations hash does not match to expected
216: require(s.totalBlocksExecuted <= s.totalBlocksVerified, "n");
237: require(_hashStoredBlockInfo(_prevBlock) == s.storedBlockHashes[currentTotalBlocksVerified], "t1");
241: require(
261: require(successVerifyProof, "p"); // Proof verification fail
265: require(successProofAggregation, "hh"); // Proof aggregation must be valid
268: require(currentTotalBlocksVerified <= s.totalBlocksCommitted, "q");
297: require(_recurisiveAggregationInput.length == 4);
337: require(s.totalBlocksCommitted > _newLastBlock, "v1"); // the last committed block is less new last blockFile: /ethereum/contracts/zksync/facets/Getters.sol
148: require(ds.selectorToFacet[_selector].facetAddress != address(0), "g2");File: /ethereum/contracts/zksync/facets/Governance.sol
30: require(msg.sender == pendingGovernor, "n4"); // Only proposed by current governor address can claim the governor rightsFile: /ethereum/contracts/zksync/facets/Mailbox.sol
56: require(_blockNumber <= s.totalBlocksExecuted, "xx");
63: require(hashedLog != L2_L1_LOGS_TREE_DEFAULT_LEAF_HASH, "tw");
66: require(_proof.length == L2_TO_L1_LOG_MERKLE_TREE_HEIGHT, "rz");
124: require(_ergsLimit <= PRIORITY_TX_MAX_ERGS_LIMIT, "ui");File: /ethereum/contracts/zksync/DiamondProxy.sol
13: require(_chainId == block.chainid, "pr");
24: require(msg.data.length >= 4 || msg.data.length == 0, "Ut");
29: require(facetAddress != address(0), "F"); // Proxy has no facet for this selector
30: require(!diamondStorage.isFrozen || !facet.isFreezable, "q1"); // Facet is frozenhttps://github.com/code-423n4/2022-10-zksync/blob/main/ethereum/contracts/zksync/DiamondProxy.sol
File: /ethereum/contracts/bridge/L1ERC20Bridge.sol
77: require(_factoryDeps.length == 2, "mk");
117: require(amount > 0, "1T"); // empty deposit amount
207: require(success, "yn");
210: require(amount > 0, "y1");
232: require(!isWithdrawalFinalized[_l2BlockNumber][_l2MessageIndex], "pw");
249: require(success, "nq");
271: require(_l2ToL1message.length == 76, "kk");
274: require(bytes4(functionSignature) == this.finalizeWithdrawal.selector, "nt");File: /ethereum/contracts/bridge/L1EthBridge.sol
93: require(_l1Token == CONVENTIONAL_ETH_ADDRESS, "bx");
141: require(_l1Token == CONVENTIONAL_ETH_ADDRESS, "sj");
145: require(amount != 0);
166: require(success, "ju");
189: require(!isWithdrawalFinalized[_l2BlockNumber][_l2MessageIndex], "jj");
205: require(success, "rj");
221: require(_message.length == 56);
224: require(bytes4(functionSignature) == this.finalizeWithdrawal.selector);
238: require(callSuccess);https://github.com/code-423n4/2022-10-zksync/blob/main/ethereum/contracts/bridge/L1EthBridge.sol
File: /ethereum/contracts/common/AllowList.sol
33: require(_owner != address(0), "kq");
38: require(msg.sender == owner, "kx");
67: require(targetsLength == _enables.length, "yg"); // The size of arrays should be equal
96: require(
155: require(msg.sender == newOwner, "n0"); // Only proposed by current owner address can claim the owner rightshttps://github.com/code-423n4/2022-10-zksync/blob/main/ethereum/contracts/common/AllowList.sol
File: /ethereum/contracts/common/AllowListed.sol
15: require(_allowList.canCall(msg.sender, address(this), functionSig), "nr");https://github.com/code-423n4/2022-10-zksync/blob/main/ethereum/contracts/common/AllowListed.sol
File: /ethereum/contracts/common/L2ContractHelper.sol
50: require(_bytecode.length % 32 == 0, "po");
53: require(bytecodeLenInWords < 2**16, "pp"); // bytecode length must be less than 2^16 words
54: require(bytecodeLenInWords % 2 == 1, "pr"); // bytecode length in words must be odd
65: require(version == 1 && _bytecodeHash[1] == bytes1(0), "zf"); // Incorrectly formatted bytecodeHash
67: require(bytecodeLen(_bytecodeHash) % 2 == 1, "uy"); // Code length in words must be oddFile: /ethereum/contracts/common/ReentrancyGuard.sol
55: require(lockSlotOldValue == 0, "1B");
72: require(_status == _NOT_ENTERED, "r1");File: /zksync/contracts/bridge/L2ERC20Bridge.sol
58: require(msg.sender == l1Bridge, "mq");
63: require(deployedToken == expectedL2Token, "mt");
95: require(l1Token != address(0), "yh");https://github.com/code-423n4/2022-10-zksync/blob/main/zksync/contracts/bridge/L2ERC20Bridge.sol
File: /zksync/contracts/bridge/L2ETHBridge.sol
49: require(msg.sender == l1Bridge, "ni");
50: require(_l1Token == CONVENTIONAL_ETH_ADDRESS);
64: require(_l2Token == CONVENTIONAL_ETH_ADDRESS, "zn");https://github.com/code-423n4/2022-10-zksync/blob/main/zksync/contracts/bridge/L2ETHBridge.sol
File: /zksync/contracts/bridge/L2StandardERC20.sol
44: require(l1Address == address(0), "in5"); // Is already initialized
45: require(_l1Address != address(0), "in6"); // Should be non-zero address
96: require(msg.sender == l2Bridge);