Skip to content

Latest commit

 

History

History
50 lines (27 loc) · 3.54 KB

sakman-Q.md

File metadata and controls

50 lines (27 loc) · 3.54 KB

1. TODOs

ethereum/contracts/zksync/interfaces/IExecutor.sol: L56

2. Events not emmited

ethereum/contracts/bridge/L1EthBridge.sol: L56

ethereum/contracts/bridge/L1ERC20Bridge.sol: L71

3. Use external instead of public for the following functions

zksync/contracts/bridge/L2StandardERC20.sol: L126

ethereum/contracts/common/AllowList.sol: L29

ethereum/contracts/bridge/L1ERC20Bridge.sol: L274 L282

ethereum/contracts/zksync/facets/Mailbox.sol: L89

ethereum/contracts/bridge/L1EthBridge.sol: L243

zksync/contracts/bridge/L2ETHBridge.sol: L79 L84

4. Event is missing indexed fields

zksync/contracts/bridge/L2StandardERC20.sol: L12

ethereum/contracts/zksync/libraries/Diamond.sol: L16

ethereum/contracts/bridge/interfaces/IL1Bridge.sol: L11 L13

ethereum/contracts/zksync/interfaces/IExecutor.sol: L85

5. Missing natspec

zksync/contracts/bridge/interfaces/IL2StandardToken.sol: L1

ethereum/contracts/common/libraries/UncheckedMath.sol: L1

zksync/contracts/bridge/interfaces/IL2EthInitializable.sol: L1

ethereum/contracts/zksync/interfaces/IZkSync.sol: L1

zksync/contracts/L2ContractHelper.sol: L1

ethereum/contracts/zksync/interfaces/IDiamondCut.sol: L1