Skip to content

Latest commit

 

History

History
37 lines (25 loc) · 1.45 KB

seyni-Q.md

File metadata and controls

37 lines (25 loc) · 1.45 KB

QA

[N-01] Incomplete Natspec

Some function parameters are not described in Natspec comments in the initialize function.

DiamondInit.sol#L25

    function initialize(

[N-02] Typo in Executor.sol

The input variable _recurisiveAggregationInput may have been intended to be called _recursiveAggregationInput.

Executor.sol#L296

    function _verifyRecursivePartOfProof(uint256[] calldata _recurisiveAggregationInput) internal view returns (bool) {

[N-03] Dead code: _calculateBlockHash is not used in Executor.sol

The function Executor._calculateBlockHash is internal and is not used in any of the contracts. The code should be removed or the visibility should be changed to external.

Executor.sol#L80-L86

    function _calculateBlockHash(StoredBlockInfo memory _previousBlock, CommitBlockInfo calldata _newBlock)
        internal
        pure
        returns (bytes32)
    {
        return keccak256(abi.encode(_previousBlock.blockHash, _newBlock.newStateRoot));
    }