From 4f36b3e025091d0bed4977dacb5666eeedb1147b Mon Sep 17 00:00:00 2001
From: C4 <81770958+code423n4@users.noreply.github.com>
Date: Thu, 29 Dec 2022 00:36:15 +0100
Subject: [PATCH] Report for issue #65 updated by RaymondFam

---
 data/RaymondFam-Q.md | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/data/RaymondFam-Q.md b/data/RaymondFam-Q.md
index da4d544..1e6e74f 100644
--- a/data/RaymondFam-Q.md
+++ b/data/RaymondFam-Q.md
@@ -192,4 +192,18 @@ Consider moving the needed assignment before the conditional statement by having
 -		if ((assets = previewRedeem(shares)) == 0) {
 +		assets = previewRedeem(shares);
 +		if (assets == 0) {
+```
+## Zero value check on `withdrawAVAX() in TokenggAVAX.sol
+Although `previewWithdraw()` does round up, it could still assign a zero value to `shares` if the input parameter, `assets` is accidentally entered as zero. Consider having a zero value check implemented just as it has been done so on `redeemAVAX()` which is nonetheless a side effect zero value check arising from rounding error check associated with round down issue in `previewRedeem()`.
+
+[File: TokenggAVAX.sol#L180-L189](https://github.com/code-423n4/2022-12-gogopool/blob/main/contracts/contract/tokens/TokenggAVAX.sol#L180-L189)
+
+```diff
+	function withdrawAVAX(uint256 assets) public returns (uint256 shares) {
++		if (assets == 0) {
++			revert ZeroAssets();
+
+		shares = previewWithdraw(assets); // No need to check for rounding error, previewWithdraw rounds up.
+		beforeWithdraw(assets, shares);
+		_burn(msg.sender, shares);
 ```
\ No newline at end of file