Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis #916

Open
CloudEllie opened this issue Jul 5, 2023 · 4 comments
Open

Analysis #916

CloudEllie opened this issue Jul 5, 2023 · 4 comments
Labels
analysis grade-b satisfactory satisfies C4 submission criteria; eligible for awards sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@CloudEllie
Copy link
Contributor

A. Approach to codebase evaluation:

Team members had individual approaches. Leader focused on UniswapV3 staking. Initial plan of brief overview followed by deep dives didn't work as intended. Collaboration was effective. Script used to find zero address checks and external functions. Codebase exploration prioritized over documentation.

B. Key learnings:

Team members gained knowledge of bridges and omnichain gas management. Leader learned about staking, NFT positions, gauges, and the complex contract ecosystem. Difficulty in finding vulnerabilities due to codebase size and previous audits. Importance of balancing large and small LOC contests.

C. Comments for the judge:

Limited focus on gas optimization. Efforts to find bugs in omnichain areas resulted in false flags. Spotting lack of zero address checks was straightforward. Time constraints and power interruption affected team leader's submission.

Team members' answers:
Approaches included light doc review, function analysis. Extensive research on contract relationships and identifying unreachable code.

@CloudEllie
Copy link
Contributor Author

Staff note: this team's Analysis was submitted slightly late (1 hour after the audit closed), but since Analyses are relatively new, and may be weighed by the judge when reviewing issues, I have made the call to add this one manually. I leave it to the judge to decide whether to consider it for evaluation.

@c4-judge
Copy link
Contributor

c4-judge commented Jul 7, 2023

trust1995 marked the issue as grade-b

@c4-judge c4-judge added the satisfactory satisfies C4 submission criteria; eligible for awards label Jul 7, 2023
@c4-judge
Copy link
Contributor

c4-judge commented Jul 7, 2023

trust1995 marked the issue as satisfactory

@c4-sponsor
Copy link

0xLightt marked the issue as sponsor confirmed

@c4-sponsor c4-sponsor added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis grade-b satisfactory satisfies C4 submission criteria; eligible for awards sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Development

No branches or pull requests

3 participants