Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Store Tag Serializer Code as a **tagging** app for Use Across Endpoints #86

Closed
BethanyG opened this issue Feb 22, 2020 · 2 comments · Fixed by #96
Closed

[API] Store Tag Serializer Code as a **tagging** app for Use Across Endpoints #86

BethanyG opened this issue Feb 22, 2020 · 2 comments · Fixed by #96
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@BethanyG
Copy link
Member

BethanyG commented Feb 22, 2020

Currently, we are assuming most endpoints will have Tags and we are also using taggit for tag management.

Our current taggit model required custom serializer code to make tags for resources display appropriately, and the expectation is that this same code (or some improved or different version) will be required for any endpoint that is using taggit or tags.

We should therefore move the TagSerializer and TagsSerializerField code out of resources, and into a common utility file or location for ease of import and use to other endpoints (and to better discuss and maintain it as a module).

Propose it be moved to the utils.py file, where we also have the jwt response handler code...or another common or core place.

Propose a tagging app for storing tagging related serializers, views, and functions.

@BethanyG BethanyG added enhancement New feature or request needs discussion The fix for this issue needs discussion labels Feb 22, 2020
@BethanyG BethanyG self-assigned this Feb 26, 2020
@billglover
Copy link
Contributor

Based on conversation on Slack it looks like a decision was made to move this to its own app (also known as a module).

@billglover billglover removed the needs discussion The fix for this issue needs discussion label Feb 26, 2020
@billglover billglover added this to the projects milestone Feb 26, 2020
@BethanyG BethanyG changed the title [API] Make Tag Serializer Code a Utility for Use Across Endpoints [API] Store Tag Serializer Code a **tagging** app for Use Across Endpoints Feb 26, 2020
@BethanyG BethanyG changed the title [API] Store Tag Serializer Code a **tagging** app for Use Across Endpoints [API] Store Tag Serializer Code as a **tagging** app for Use Across Endpoints Feb 26, 2020
@BethanyG
Copy link
Member Author

BethanyG commented Feb 26, 2020

Yes. Following the recommendation of Kenneth. Changed the issue title/description accordingly. This will be part of the PR that includes #71, #72 & #74.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants