You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, we are assuming most endpoints will have Tags and we are also using taggit for tag management.
Our current taggit model required custom serializer code to make tags for resources display appropriately, and the expectation is that this same code (or some improved or different version) will be required for any endpoint that is using taggit or tags.
We should therefore move the TagSerializer and TagsSerializerField code out of resources, and into a common utility file or location for ease of import and use to other endpoints (and to better discuss and maintain it as a module).
Propose it be moved to the utils.py file, where we also have the jwt response handler code...or another common or core place.
Propose a tagging app for storing tagging related serializers, views, and functions.
The text was updated successfully, but these errors were encountered:
BethanyG
changed the title
[API] Make Tag Serializer Code a Utility for Use Across Endpoints
[API] Store Tag Serializer Code a **tagging** app for Use Across Endpoints
Feb 26, 2020
BethanyG
changed the title
[API] Store Tag Serializer Code a **tagging** app for Use Across Endpoints
[API] Store Tag Serializer Code as a **tagging** app for Use Across Endpoints
Feb 26, 2020
Yes. Following the recommendation of Kenneth. Changed the issue title/description accordingly. This will be part of the PR that includes #71, #72 & #74.
Currently, we are assuming most endpoints will have Tags and we are also using
taggit
for tag management.Our current
taggit
model required custom serializer code to make tags forresources
display appropriately, and the expectation is that this same code (or some improved or different version) will be required for any endpoint that is usingtaggit
or tags.We should therefore move the TagSerializer and TagsSerializerField code out of
resources
, and into a commonutility file orlocation for ease of import and use to other endpoints (and to better discuss and maintain it as a module).Propose it be moved to theutils.py
file, where we also have the jwt response handler code...or another common or core place.Propose a tagging app for storing tagging related serializers, views, and functions.
The text was updated successfully, but these errors were encountered: