Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Ruby 3.x compatibility #121

Closed
n-rodriguez opened this issue Dec 26, 2020 · 6 comments
Closed

Ruby 3.x compatibility #121

n-rodriguez opened this issue Dec 26, 2020 · 6 comments

Comments

@n-rodriguez
Copy link

Ruby 3 is out and codecov-ruby is not compatible with it :

it fallbacks to codecov 0.2.12 :

Using codecov 0.2.12 (was 0.2.15)

-    codecov (0.2.15)
-      simplecov (>= 0.15, < 0.21)
+    codecov (0.2.12)
+      json
+      simplecov

Because of b8fad69#diff-04cb1f7276546201ae5ccb1c2165c2b6c9ed202c6e6d7dd4ea803e32386a7dc2

@AlexWayfer
Copy link
Contributor

Ruby 3 is out and codecov-ruby is not compatible with it :

it fallbacks to codecov 0.2.12 :

Using codecov 0.2.12 (was 0.2.15)

-    codecov (0.2.15)
-      simplecov (>= 0.15, < 0.21)
+    codecov (0.2.12)
+      json
+      simplecov

Because of b8fad69#diff-04cb1f7276546201ae5ccb1c2165c2b6c9ed202c6e6d7dd4ea803e32386a7dc2

And what does it have to do with Ruby 3?

@n-rodriguez
Copy link
Author

And what does it have to do with Ruby 3?

It's painfuly obvious you dont know how your tools work...

@AlexWayfer
Copy link
Contributor

And what does it have to do with Ruby 3?

It's painfuly obvious you dont know how your tools work...

You didn't answered. You've wrote "codecov is not compatible with Ruby 3" and attached Gemfile.lock diff without Ruby 3 information, specific, at least clarification.

Oh, I got it: you meant this diff as result, not as reason. Sorry. OK.

@AlexWayfer
Copy link
Contributor

@n-rodriguez closed this 10 hours ago

Why? I agreed with the issue and apologized. It's still here, and though changes in your PR was dangerous (step back), I've suggested more safe changes for resolution this issue. There is a button to accept them and the PR can be merged.

@n-rodriguez
Copy link
Author

Someone else will do the job better than me.

@thomasrockhu
Copy link
Contributor

Thanks all, this will be released shortly and fixed via #124

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants