Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ComponentsTab placeholder under RepoPage #1370

Closed
1 task done
Tracked by #234
JerrySentry opened this issue Mar 9, 2024 · 2 comments
Closed
1 task done
Tracked by #234

Add ComponentsTab placeholder under RepoPage #1370

JerrySentry opened this issue Mar 9, 2024 · 2 comments
Assignees

Comments

@JerrySentry
Copy link

JerrySentry commented Mar 9, 2024

Design doc: https://www.figma.com/file/lpCAamL0oUGKvVng0g7vex/GH-234?type=design&node-id=1-2&mode=design&t=9bBDzCMR6WmyCZZ8-0

  1. Copy everything from FlagsTab under RepoPage for this, change the following from Flags to Components:

    • static texts
    • file names
    • function names (except still use useActivateFlagMeasurements and keep function calls outside of the ComponentsTab to be the same, we will do that later)
  2. Basically at the end this new table shows and functions the same way as FlagsTab except everything is showing as Components and in the code the only useRepoBackfillingStatus it is fetching from Flags

  3. Request new asset for blurredTable.png

  4. Make sure FlagsTab is not actually showing in the RepoPage (only show internally via Feature Flag)

  5. Request Components Tab feedback Feedback on the new 'Flags' tab feedback#27

Blocked By

Preview Give feedback
  1. ajay-sentry
@JerrySentry JerrySentry changed the title Add ComponentsTab under RepoPage Add ComponentsTab placeholder under RepoPage Mar 9, 2024
@RulaKhaled
Copy link

RulaKhaled commented Mar 12, 2024

  • Let's ask marketing for blurredTable.png
  • Let's attach design links to all subtasks that requires client changes
  • Add a Note: Change and Last updated are two new columns that need to be added here
  • Confirm the expected sorting functionality
    • does icon exist in our icons library?
    • is the goal to introduce the new sorting functionality with this new table (push for no since this needs investigation)
    • what columns are we looking to sort?

@JerrySentry
Copy link
Author

  • Added PNG file request
  • Added design link
  • Change column is equivalent to the Trend column of flags, should just be a text rename
  • Last updated we will add later in this ticket Show last uploaded for each component in the table #1380
  • Sorting is a good point, that'll require a decent amount of work on both frontend and backend. Will try to push for no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants