Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Log Level Discrepancies #521

Merged
merged 1 commit into from
Apr 28, 2017
Merged

Conversation

akutz
Copy link
Collaborator

@akutz akutz commented Apr 28, 2017

This patch fixes the way the log levels are handled upon creating a new libStorage client or server. The default level remains WARN (unless the environment variable LIBSTORAGE_DEBUG=true).

When LIBSTORAGE_DEBUG=true the log level is set to DEBUG and both HTTP request and response logging are enabled.

This patch fixes the way the log levels are handled upon creating a new
libStorage client or server. The default level remains WARN (unless the
environment variable LIBSTORAGE_DEBUG=true).
@codecov-io
Copy link

codecov-io commented Apr 28, 2017

Codecov Report

Merging #521 into master will increase coverage by 0.11%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #521      +/-   ##
=========================================
+ Coverage   27.99%   28.1%   +0.11%     
=========================================
  Files          33      33              
  Lines        1997    2010      +13     
=========================================
+ Hits          559     565       +6     
- Misses       1379    1384       +5     
- Partials       59      61       +2
Impacted Files Coverage Δ
api/context/context_keys.go 65.38% <25%> (-10.13%) ⬇️
api/context/context.go 30.73% <76.92%> (+2.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0c9d72...402b88e. Read the comment docs.

@akutz akutz merged commit 003b158 into thecodeteam:master Apr 28, 2017
@akutz akutz deleted the bugfix/log-levels branch April 29, 2017 03:33
@codenrhoden codenrhoden modified the milestone: 2017.04 May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants