Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up CI #4

Closed
hartsick opened this issue Sep 6, 2018 · 2 comments
Closed

Set up CI #4

hartsick opened this issue Sep 6, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@hartsick
Copy link
Contributor

hartsick commented Sep 6, 2018

In developing this thing, I feel like we could use a setup on Circle CI with a few things:

When PR opened:

  • Run specs (we have a few!)
  • Explore: publish to review app, so changes can be reviewed visually (punted pending screenshot testing)
  • Explore: Using happo.io for screenshot testing (moved to Explore screenshot testing #51)

When merged to master:

  • Publish to a staging environment where we have a dummy application using our gem (to do when we feel a real need)
@hartsick hartsick added the enhancement New feature or request label Sep 6, 2018
@hartsick
Copy link
Contributor Author

hartsick commented Dec 3, 2018

Adding some quick notes from conversation with Henric of Happo.io:

To start, we could set up Happo on our main styleguide page and programmatically pull components from the examples directory we currently use to build the HTML. It will include some things (for example, buttons) in one diff when they're actually different components, but should be good to start. He mentioned that other companies usually have some grouping of components.

The main thing he flagged is that we'll need to grab the precompiled CSS before running Happo. @tdooner mentioned they used to do this when they worked together at Brigade. Henric also mentioned he used to work in Ruby/Rails in past, and would be interested in working with us to help get set up.

In future, we could potentially spin up multiple environments with each of the apps using the styleguide and test against them.

@hartsick
Copy link
Contributor Author

Closing this since we have basic CI set up that runs our specs—I've opened another issue to explore screenshot testing: #51.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant