Many spec failures on master

[ignu]

Not sure if this is just me. I don't see a link to the Travis build anywhere.

327 examples, 46 failures, 8 pending

Failed examples:

rspec ./spec/api/locations_spec.rb:374 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) validates location URLs
rspec ./spec/api/locations_spec.rb:308 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) requires contact name
rspec ./spec/api/locations_spec.rb:507 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) rejects location with neither address nor mail address
rspec ./spec/api/locations_spec.rb:463 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) requires location mail_address street
rspec ./spec/api/locations_spec.rb:548 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) updates the Elasticsearch index when location changes
rspec ./spec/api/locations_spec.rb:412 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) requires location address state
rspec ./spec/api/locations_spec.rb:299 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) validates contact email
rspec ./spec/api/locations_spec.rb:445 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) validates location mail address state
rspec ./spec/api/locations_spec.rb:209 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) allows setting whitelisted attributes
rspec ./spec/api/locations_spec.rb:356 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) requires location name
rspec ./spec/api/locations_spec.rb:267 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) allows empty fax number
rspec ./spec/api/locations_spec.rb:274 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) strips out empty emails from array
rspec ./spec/api/locations_spec.rb:344 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) limits short description to 200 characters
rspec ./spec/api/locations_spec.rb:454 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) validates location mail address zip
rspec ./spec/api/locations_spec.rb:474 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) requires location mail_address state
rspec ./spec/api/locations_spec.rb:258 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) validates fax number is an array
rspec ./spec/api/locations_spec.rb:434 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) requires location address zip
rspec ./spec/api/locations_spec.rb:201 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) doesn't allow setting non-whitelisted attributes
rspec ./spec/api/locations_spec.rb:241 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) validates fax number
rspec ./spec/api/locations_spec.rb:326 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) requires description
rspec ./spec/api/locations_spec.rb:290 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) validates contact fax
rspec ./spec/api/locations_spec.rb:524 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) geocodes when address has changed
rspec ./spec/api/locations_spec.rb:365 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) validates location email
rspec ./spec/api/locations_spec.rb:383 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) validates location address state
rspec ./spec/api/locations_spec.rb:249 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) validates fax number is a hash
rspec ./spec/api/locations_spec.rb:317 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) requires contact title
rspec ./spec/api/locations_spec.rb:281 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) validates contact phone
rspec ./spec/api/locations_spec.rb:217 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) validates the kind attribute
rspec ./spec/api/locations_spec.rb:233 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) validates phone number
rspec ./spec/api/locations_spec.rb:496 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) requires location mail_address zip
rspec ./spec/api/locations_spec.rb:423 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) requires location address city
rspec ./spec/api/locations_spec.rb:535 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) resets coordinates when address is removed
rspec ./spec/api/locations_spec.rb:401 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) requires location address street
rspec ./spec/api/locations_spec.rb:335 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) requires short description
rspec ./spec/api/locations_spec.rb:225 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) validates the accessibility attribute
rspec ./spec/api/locations_spec.rb:392 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) validates location address zip
rspec ./spec/api/locations_spec.rb:485 # Ohana::API Location Requests Update a location (PUT /api/locations/:id) requires location mail_address city
rspec ./spec/api/locations_spec.rb:580 # Ohana::API Location Requests Create a location (POST /api/locations/) doesn't allow setting non-whitelisted attributes
rspec ./spec/api/services_spec.rb:33 # Ohana::API PUT Requests for Services PUT /api/services/:id/ validates service areas
rspec ./spec/api/services_spec.rb:42 # Ohana::API PUT Requests for Services PUT /api/services/:id/ ensures keywords is an array
rspec ./spec/api/services_spec.rb:24 # Ohana::API PUT Requests for Services PUT /api/services/:id/ updates Elasticsearch index when service changes
rspec ./spec/api/services_spec.rb:14 # Ohana::API PUT Requests for Services PUT /api/services/:id/ doesn't allow setting non-whitelisted attributes
rspec ./spec/api/services_spec.rb:51 # Ohana::API PUT Requests for Services PUT /api/services/:id/ ensures service_areas is an array
rspec ./spec/api/organizations_spec.rb:109 # Ohana::API GET Requests PUT /api/organizations/:id doesn't allow setting non-whitelisted attributes
rspec ./spec/api/organizations_spec.rb:118 # Ohana::API GET Requests PUT /api/organizations/:id allows setting whitelisted attributes
rspec ./spec/api/organizations_spec.rb:126 # Ohana::API GET Requests PUT /api/organizations/:id updates Elasticsearch index when org name changes

[monfresh]

Hi @ignu, thanks for your interest in Ohana API! The errors you are seeing are most likely due to your application.yml missing a value for ADMIN_APP_TOKEN. Please refer to this section of the installation instructions: https://github.com/codeforamerica/ohana-api#install-the-dependencies-and-prepare-the-db

Let me know if that solves the issue or if the instructions aren't clear.

[monfresh]

Hi @ignu, are you still seeing this issue?

[ignu]

nope, sorry for overlooking that!