Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip extension delimiter from phone extension #241

Closed
anselmbradford opened this issue Oct 11, 2014 · 1 comment
Closed

Strip extension delimiter from phone extension #241

anselmbradford opened this issue Oct 11, 2014 · 1 comment
Labels

Comments

@anselmbradford
Copy link
Member

In the demo data there are some phone extensions that are, for example, Ext. 4385 and others that are x42. The delimiter (Ext. or x) should be stripped out of the data so that field only contains the extension number. The client can then set a delimiter so it's consistent in presentation across all entries. If a customized delimiter is needed (though I don't see why this would be necessary) that can be a setting in https://github.com/codeforamerica/ohana-web-search/blob/master/config/settings.yml

@monfresh
Copy link
Member

This is an Open Referral data standard issue. v0.2 of the spec currently does not specify the formatting of the extension field. If you think the extension field should only contain a number (I think that's probably a good idea), then please add a comment to the spec. Once the spec is finalized, I will update the API to enforce that rule.

On the other hand, if the spec does not enforce a digit-only rule, then the API should not alter the data that is stored in the database. It would then be up to the client to format the data to suit its needs.

So, since this is not a bug in the API code, I will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants