Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ask_for field is not an array in many cases #59

Closed
anselmbradford opened this issue Jul 9, 2013 · 3 comments
Closed

ask_for field is not an array in many cases #59

anselmbradford opened this issue Jul 9, 2013 · 3 comments
Assignees
Labels

Comments

@anselmbradford
Copy link
Member

ask_for field is defined as an array in the organization model (https://github.com/codeforamerica/ohana-api/blob/master/app/models/organization.rb#L7) but is a comma or space delimited string in many cases. E.g.:
http://ohanapi.herokuapp.com/api/organizations/51d5b18ba4a4d8b01b3e3f6d
http://ohanapi.herokuapp.com/api/organizations/51d5b18ba4a4d8b01b3e3f6d

@ghost ghost assigned spara Jul 11, 2013
@spara
Copy link

spara commented Jul 16, 2013

The ask_for field can't be an array because there are too many variations in the way it is entered to parse it coherently. Consider these:

Peg Morris (Executive Director)
Jacqueline Raine, Becky Bogyo, Justin Skinner, Sheryl Munoz-Bergman (ESL/Citizenship classes)
Access Department (650-688-3625)
Laura Fanucchi (Homesharing Program) Carolyn Moore (Self-Sufficiency Program)
Diane Smith (Associate Director)
Melissa Platte
Sue Digre (Director of Family Services) or Pati Vicari (Director of Programs)

Sorry, but there isn't much to be done unless someone manually goes through these.

Won't fix.

@spara spara closed this as completed Jul 16, 2013
@anselmbradford
Copy link
Member Author

@spara Could we break them at ") " or ", " or "), " ... won't catch them all, but would catch a lot of the above.

@spara
Copy link

spara commented Jul 23, 2013

Implemented the request to separate ask_for into array of contacts. Not perfect, about >100 entries will require corrections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants