Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primrose Center has incorrect phones array #60

Closed
anselmbradford opened this issue Jul 11, 2013 · 5 comments
Closed

Primrose Center has incorrect phones array #60

anselmbradford opened this issue Jul 11, 2013 · 5 comments
Assignees

Comments

@anselmbradford
Copy link
Member

http://ohanapi.herokuapp.com/api/organizations/51d5b18ca4a4d8b01b3e42c0 has the following phones array:

phones: [
   [
      {
         number: "650 342-2255",
         phone_hours: "(Monday-Friday, 9-3)"
      }
   ],
   [
      {
         department: "650-342-CALL"
      }
   ]
]

department should be number.

@ghost ghost assigned spara Jul 11, 2013
@spara
Copy link

spara commented Jul 11, 2013

It gets classified as department because of the characters in the phone number, will change regex to accomodate this

@anselmbradford
Copy link
Member Author

Or maybe have an alias field in the first entry? I mean 650-342-CALL is the same number.

@spara
Copy link

spara commented Jul 11, 2013

Doable, I'll need to write a decoder (26 case statement) and compare them.

@anselmbradford
Copy link
Member Author

Here's another one with letters in the number: http://ohanapi.herokuapp.com/api/organizations/51d5b18ba4a4d8b01b3e3f57

@spara
Copy link

spara commented Jul 16, 2013

Fixed

@spara spara closed this as completed Jul 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants