-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entries with mailing address only should not have coordinates #96
Comments
Geocoding is only done on entries with a physical address. FraudNET does have a physical address, so I need to find out why it's not being returned by the API. |
Wait, the API is returning the address: http://ohanapi.herokuapp.com/api/locations/521d33951974fcdb2b0025e1 |
Looks like it's a front-end issue actually, I see the addresses in the returned values. |
ok. closing this here then. |
@migurski 's point though is that things like hotlines that are tied to a physical address that's far from SMC are problematic in terms of display on the map as well as search. For example, if someone searches for "smokers helpline" in "Redwood City", they should still have the California hotline in the results, but they don't because it has a physical address in Southern California. It seems it should be considered whether entries without a reasonable expectation of being visited should not have a physical address, or perhaps this is something the |
Per feedback from @migurski, entries that have only a mailing address and not a physical address, such as
FraudNET
(521d33951974fcdb2b0025e1
) should not have coordinates so that they are excluded from showing up on the map. The map is for entries that our audience may actually reasonably be expected to visit (FraudNET
, in particular, has a DC mailing address). Another example isCalifornia Smokers' Helpline
, which has a southern California mailing address only, yet is plotted on the map.The text was updated successfully, but these errors were encountered: