Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Code to 1.89 #6782

Closed
benz0li opened this issue May 2, 2024 · 4 comments · Fixed by #6783
Closed

Update Code to 1.89 #6782

benz0li opened this issue May 2, 2024 · 4 comments · Fixed by #6783
Assignees
Labels
enhancement Some improvement that isn't a feature

Comments

@benz0li
Copy link
Contributor

benz0li commented May 2, 2024

What is your suggestion?

Update Code to 1.89

Why do you want this feature?

Are there any workarounds to get this functionality today?

Are you interested in submitting a PR for this?

@benz0li benz0li added the enhancement Some improvement that isn't a feature label May 2, 2024
@benz0li
Copy link
Contributor Author

benz0li commented May 2, 2024

Expected release date: 05/02 (this may change)

microsoft/vscode#210887

@benz0li
Copy link
Contributor Author

benz0li commented May 2, 2024

@code-asher
Copy link
Member

Building with Node.js > 18.19 should work now.

Nice work!

@benz0li
Copy link
Contributor Author

benz0li commented May 3, 2024

Code - OSS v1.89.0 was released yesterday: https://github.com/microsoft/vscode/releases/tag/1.89.0

I am in the process of creating a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants