Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab oauth2:token being written to .git/config file after cloning #126

Closed
Tracked by #132
ns-mkusper opened this issue Apr 15, 2024 · 1 comment · Fixed by #141
Closed
Tracked by #132

Gitlab oauth2:token being written to .git/config file after cloning #126

ns-mkusper opened this issue Apr 15, 2024 · 1 comment · Fixed by #141
Assignees

Comments

@ns-mkusper
Copy link

I'm using envbuilder 0.2.9 and allowing my users to set the branch portion of the GIT_URL (by using a parameter in the #refs/heads/${data.coder_parameter.repo_branch.value} value) in new workspaces via the form parameters. This works, but when the repo gets cloned the credentials I set to GIT_USERNAME and GIT_PASSWORD for envbuilder to be able to pull the repo are written to .git/config (as explained in the readme ) which then overrides any token refreshing as the config takes priority over GIT_ASKPASS.

As a workaround I am just clearing this via a startup script, but this seems to be a bug.

@coder-labeler coder-labeler bot added the bug label Apr 15, 2024
@bpmct bpmct mentioned this issue Apr 18, 2024
36 tasks
@bpmct
Copy link
Member

bpmct commented Apr 18, 2024

related #91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants