[desktop] Toolbar discussion #195
Comments
|
@twiss: thank you for catching this! It is definitely a bad user experience. A possible fix is to change https://github.com/codexa/firetext/blob/develop/scripts/firetext.js#L1139-L1152 to only run when I would be delighted to provide guidance if you would like to solve the issue =) |
|
Yes, that's probably the best solution. The only question is, do you want that in zen mode as well? Some people might like the reduced clutter, and for some reason this bug doesn't happen in full screen in Firefox, but it's a lot of mouse moving on a 1080p screen, which you could partially solve by moving the button to the left. What do you think/prefer? |
|
... the downside of which is that it obstructs the text you're typing more. So, unless you disagree, I'll send a PR with your original proposal tomorrow. |
|
@twiss: sorry for the delay. Which button are you referring to? The hide keyboard button? Also, does the editor show/hide on |
|
@twiss: IMO the "hide-keyboard" button does not make sense in the desktop form factor. Although, zen mode is supposed to be distraction-free, so it may apply there. How does this sound? In zen mode:
In regular mode:
You can tell if the document is in zen mode by checking to see if the Thank you for being willing to fix this 👍! |
Yes, that's actually what I was talking about, sorry for being unclear. The main reason not to do that would be that on a large screen, moving your mouse from top-left (where your text is) to bottom-right (show-toolbar/hide-keyboard) to bottom-left (toolbar) to top-left is not fun. Possible solutions (I'm only talking about zen mode now):
|
I like this idea! We could hide the hide-keyboard button on desktop, and hide the show-toolbar button on mobile. This does not fall within the scope of this issue, but I have been considering auto-hiding the header on mobile (possibly using http://wicky.nillia.ms/headroom.js/). In the zen mode desktop interface, we could use the show-toolbar button instead. |
Right, that's also a possibility. Where would you place hide-keyboard and the toolbar on mobile? If you place them top-right, it's a strange place for a hide-keyboard button, and if bottom-right, the place of the toolbar is then different between mobile and desktop (which I guess is not a disaster). The nice thing about a separate show-toolbar button which doesn't hide the keyboard (at least in my theory) is that you can continue working without having the keyboard dis- and reappear. Although this might be influenced by my experience on my Android, where the keyboard is very slow to come up. How's that in practice on Firefox OS? |
|
Here are some screenshots of Firetext on mobile. I would not recommend that we change placement of the toolbar/hide-keyboard button:
On the desktop form factor, however, toolbar-on-the-top is a popular design pattern. I don't believe that there will be a problem with placing the toolbar in a different location for desktop. A visible show-toolbar button might be useful on mobile. It could be placed on the left of the hide-keyboard button. Do you think that the feature is worth the space it would occupy? |
|
Thanks for the screenshots, that's helpful.
IMO it depends on how smooth and fast the select text, show toolbar, tap button, continue typing cycle is. If you can make that smoother or faster by not hiding the keyboard, I think it's worth it. I'd have to try it out to tell if that's the case, though. Also, two unrelated questions based on your screenshots:
|
|
It is definitely a balance between interaction speed and the conservation of display real-estate. Have you tried testing on the Firefox OS simulator (explained here: https://github.com/codexa/firetext/wiki/Get-Coding#using-the-simulator)?
|
|
Yes, it doesn't work (Issue #177), I should get a device. In the meantime, I'll leave it like it is. |
|
As of which version does the spacebar hide the keyboard? I couldn't discover it on my Alcatel OneTouch Fire running Firefox OS v1.3. Instead I can see the currently selected language on top of the key. |
|
@Ryuno-Ki: I am not completely sure, but it is probably a 2.0/2.1 feature. |
|
@twiss how do you feel about me creating a new issue to address the hiding of the toolbar on editor |
|
Are there any statistics on Firefox OS version usage or feature usage? FWIW, apparently you can also swipe down to hide the keyboard (mozilla-b2g/gaia#10669) |
|
I don't know about statistics, but the latest release version of Firefox OS is 1.4. Some users are on the beta-nightly branches (2.0-2.2).
That is a useful feature! I tested it, and it works in some parts of the system. It doesn't work inside Firetext though... |
Go ahead. Maybe you could quote the first comments made here. (Edit: #231)
You're definitely right then to want to keep the hide-keyboard button. So my opinion is:
The only problem with that is that you may want to show/hide the toolbar based on zen mode. So maybe we should just not do that, or maybe notify the editor that we're in zen mode. |
Passed the question over to Gaia Mailinglist |
|
FYI stats for october 2014 are available now. Extracted from Firefox Marketplace. I'll look after reaching out to the marketplace folks and look into the API when I'm at home (about an hour from now). |
|
Thank you @Ryuno-Ki! |
|
Right, there was a task for me … Well, looking at the stats API for Marketplace it looks like for now, the distribution over versions cannot be requested. I filled a ticket against Mozilla: bug #1105940 |
twiss
changed the title
In Firefox desktop, when moving the mouse out of the editor and in again (which happens easily because the toolbar button is close to the edge), the editor gets focused (https://github.com/codexa/firetext/blob/0f43b6a6/scripts/firetext.js#L124 since 26f97ba) which causes the toolbar to hide, which is a bit annoying.(#231)This issue is now for general discussion about the toolbar on the desktop.
The text was updated successfully, but these errors were encountered: