Don't infer vendor directory from package name. fix for #97 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous inheritence required PSR-4 to override anyway.
And rename variables for better understandinf
The integration tests are creating a temptestdir which is deleted after each test is run, but when they fail remains.
Source of `$workingDir` is `getcwd()`. Automated tests pass on MacOS. Manual test passes on Windows: coenjacobs#90 (comment)
…OR-and-its-duplicates
…OR-and-its-duplicates
…r-vendor-directory-from-package-name.-Fix-for-#97
|
NB: This already has #103 merged into it. It's really only a few lines of changes itself. |
BrianHenryIE
deleted the
Don't-infer-vendor-directory-from-package-name.-Fix-for-#97
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
$package->pathinstead.Fixes #97.
This builds on #103 (and similarly, one of tests requires #91 merged before it will pass).