Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Motion Control - fix PassthroughPosePIDController input numbers #183

Closed
mlecriva opened this issue Feb 8, 2025 · 0 comments · Fixed by #184
Closed

Motion Control - fix PassthroughPosePIDController input numbers #183

mlecriva opened this issue Feb 8, 2025 · 0 comments · Fixed by #184
Assignees
@mlecriva
Labels
bug Something isn't working

Comments

@mlecriva
Copy link
Contributor

mlecriva commented Feb 8, 2025 •
edited
Loading

The DualPIDMetaController took 5 inputs parameters, so the PassthroughPosePIDController should take the same amount of parameters to be called by the platform engine.

The speed filter took 5 inputs parameters, so the PassthroughPosePIDController should output 5 parameters.
@mlecriva mlecriva self-assigned this Feb 8, 2025
@mlecriva mlecriva added the bug Something isn't working label Feb 8, 2025
@mlecriva mlecriva linked a pull request Feb 8, 2025 that will close this issue
motion control: fix PassthroughPosePIDController parameters number #184
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlecriva mlecriva

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

motion control: fix PassthroughPosePIDController parameters number cogip/mcu-firmware
1 participant
@mlecriva