This repository has been archived by the owner on Nov 17, 2022. It is now read-only.
Issue #68 from TB Repo - merge Commit/ Transfer support in Node
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update benchmark.zig
# Conflicts: # src/tigerbeetle
* Merge the Transfer+Commit into Transfer only
koekiebox
changed the title
Commit/ Transfer support in Node
* README.md fixes * Added myself as contributor
* Fix benchmark.sh to be in line with current TB.
* benchmark.sh updates/fixes
* Review comments from review round 2 DJ and Joran.
* 3rd round of review comments. * Single item remains.
* Review from Joran * Additional overflow checks * Updated test cases
* Cleanup of void/posted * Updated test cases * Attend to all TODO's * Remove unnecasary flag to confirm pending
* Fix benchmark.zig now that main was updated.
* Fix demo applications for new transfer/commit structure.
* Complete rework of state_machine.zig testing * Additional assertions * Review suggestions from DJ/Joran
* Add test coverage for data between pending and posted transfers
* Updates based on single Transfer for TB core.
* Update to tb-node for tb Transfer+Commit change * Test cases updated * README.md updated for startup instructions
* TB-Node to work with TB Transfer+Commit combine * Update test cases * Update benchmark * Update README.md
sentientwaffle
approved these changes
Jun 13, 2022
jorangreef
suggested changes
Jun 14, 2022
ifreund
reviewed
Jun 14, 2022
DonChangfoot
approved these changes
Jun 15, 2022
jorangreef
approved these changes
Jun 16, 2022
|
Great work @koekiebox ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2-Phase transfer is being merged into a single
Transfer, the Node client needs to be updated for the change:tigerbeetle/tigerbeetle#68