Use msgpack for storage instead of gob #52
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49
Motivation
The
gob
package requires all types to be registered. When Rosetta API implementations populate metadata (on any struct) with non-primitive values, it causedgob
to throw an error:Solution
Instead of registering all non-primitive types we could expect to see in
Metadata
(map[string]interface{}
,map[int]interface{}
,[]interface{}
, etc), theinternal/storage
package has been modified to store data asmsgpack
using this package.Not only will this change resolve #49, it also improves performance (compared to gob). Alternatively, we could have replaced
gob
withjson
but this would've caused significant performance degradation.NOTE: THIS CHANGE BREAKS ALL EXISTING STATE STORAGE! YOU WILL NEED TO CREATE A NEW DATASTORE WHEN UPDATING THE ROSETTA-CLI!