Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key Storage Backend #67

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Key Storage Backend #67

merged 2 commits into from
Jul 23, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Jul 22, 2020 •
edited
Loading

Related Issue: #68

Changes

Add KeyStorage backend for storing generated keys.KeyPairs.

@coveralls
Copy link

coveralls commented Jul 22, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1632

  • 75 of 99 (75.76%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.8%) to 61.7%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/storage/key_storage.go 75 99 75.76%
Totals Coverage Status
Change from base Build 1619: 1.8%
Covered Lines: 530
Relevant Lines: 859
💛 - Coveralls

This was referenced Jul 22, 2020
Merged
Closed
@patrick-ogrady patrick-ogrady changed the title [WIP] Automated Construction API Testing Key Storage Backend Jul 23, 2020
@patrick-ogrady patrick-ogrady merged commit 3864299 into master Jul 23, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/integrate-construction-api-testing branch July 23, 2020 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliankoh juliankoh juliankoh approved these changes

@qiwu7 qiwu7 Awaiting requested review from qiwu7

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrick-ogrady @coveralls @juliankoh