Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BroadcastStorage #80

Merged
merged 18 commits into from
Jul 27, 2020
Merged

Add BroadcastStorage #80

merged 18 commits into from
Jul 27, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Jul 26, 2020 •
edited
Loading

Related Issue: #68

BroadcastStorage tracks the broadcast and confirmation of transactions on-chain. It contains the core broadcast logic used in automated construction API testing.

Changes

  • Update BlockStorage.FindTransaction function signature based on learnings from BroadcastStorage
  • Add BroadcastStorage implementation
  • Add BroadcastStorage tests

@coveralls
Copy link

coveralls commented Jul 26, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 2326

  • 165 of 239 (69.04%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 66.711%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/storage/block_storage.go 14 25 56.0%
internal/storage/broadcast_storage.go 151 214 70.56%
Totals Coverage Status
Change from base Build 2179: 0.5%
Covered Lines: 1012
Relevant Lines: 1517
💛 - Coveralls

@patrick-ogrady patrick-ogrady changed the title Add BroadcastStorage [WIP] Add BroadcastStorage Jul 26, 2020
@patrick-ogrady patrick-ogrady mentioned this pull request Jul 26, 2020
Closed
12 tasks
@patrick-ogrady patrick-ogrady changed the title [WIP] Add BroadcastStorage Add BroadcastStorage Jul 26, 2020
@patrick-ogrady patrick-ogrady merged commit dbe09a0 into master Jul 27, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/broadcast-storage branch July 27, 2020 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yfl92 yfl92 yfl92 approved these changes

@juliankoh juliankoh Awaiting requested review from juliankoh

@qiwu7 qiwu7 Awaiting requested review from qiwu7

@niallo niallo Awaiting requested review from niallo

@etscrivner etscrivner Awaiting requested review from etscrivner

@zquestz zquestz Awaiting requested review from zquestz

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrick-ogrady @coveralls @yfl92