Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/future/image #3

Merged
merged 9 commits into from
Oct 27, 2022
Merged

next/future/image #3

merged 9 commits into from
Oct 27, 2022

Conversation

colbyfayock
Copy link
Collaborator

No description provided.

@vercel
Copy link

vercel bot commented Sep 20, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
next-cloudinary ✅ Ready (Inspect) Visit Preview Oct 27, 2022 at 8:25PM (UTC)

@colbyfayock
Copy link
Collaborator Author

https://github.com/all-contributors please add @colbyfayock for code, doc, example

@colbyfayock
Copy link
Collaborator Author

@all-contributors please add @colbyfayock for code, doc, example

@allcontributors allcontributors bot mentioned this pull request Sep 27, 2022
Merged
@allcontributors
Copy link
Contributor

@colbyfayock

I've put up a pull request to add @colbyfayock! 🎉

@colbyfayock colbyfayock mentioned this pull request Oct 14, 2022
Closed
@nucliweb
Copy link
Contributor

What do you think about defining a prop to use next/future/image or next/image.
There are a lot of legacy projects with the next/image still.

@colbyfayock
Copy link
Collaborator Author

so, my thinking here is because of the way i'm wrapping the component, CldImage doesn't necessarily care what version the component is using

i have to test to confirm this, but nothing i'm doing is using anything that's changed, it all gets passed through, and i add stuff on top by making modifications to the src based on additional Cloudinary-related props

@nucliweb
Copy link
Contributor

nucliweb commented Oct 20, 2022 •
edited
Loading

Yes, but if I want to use CldImage component but I use the Next.js version lower than 12.3 (with support to next/future/image) I will have a crash, right?

@colbyfayock
Copy link
Collaborator Author

i need to test that theory and see (or if you want to help out with that). its my understanding next/future/image will be updated to next/image in the release, it won't maintain /future so it will treat it the same, it will just have a different API

i have Next.js as a peer dependency, so there shoudln't be any version requirements iif im not mistaken

@nucliweb
Copy link
Contributor

@colbyfayock FYI, Next.js 13 will be remove /future from the component name.

@colbyfayock colbyfayock merged commit 9c271ef into main Oct 27, 2022
@colbyfayock colbyfayock deleted the future-image branch October 27, 2022 20:28
github-actions bot pushed a commit that referenced this pull request Oct 27, 2022
@semantic-release-bot
chore(release): 0.4.0 [skip ci]
913254c 
# [0.4.0](v0.3.0...v0.4.0) (2022-10-27)

### Features

* next/future/image ([#3](#3)) ([9c271ef](9c271ef))
@github-actions
Copy link

🎉 This PR is included in version 0.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

cham74 added a commit to cham74/next-image-delivery that referenced this pull request Dec 23, 2023
@cham74
chore(release): 0.4.0 [skip ci]
181b431 
# [0.4.0](cloudinary-community/next-cloudinary@v0.3.0...v0.4.0) (2022-10-27)

### Features

* next/future/image ([#3](cloudinary-community/next-cloudinary#3)) ([9c271ef](cloudinary-community/next-cloudinary@9c271ef))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colbyfayock @nucliweb