Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "gravity" is read-only #32

Merged
merged 10 commits into from
Oct 27, 2022
Merged

Fix "gravity" is read-only #32

merged 10 commits into from
Oct 27, 2022

Conversation

codingis4noobs2
Copy link
Contributor

Description

Fix "gravity" is read-only

Issue Ticket Number

Fixes [Issue #29 ]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

@codingis4noobs2
Update cropping.js
f7eeeb7 
Fix "gravity" is read-only
@vercel
Copy link

vercel bot commented Oct 16, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @colbyfayock on Vercel.

@colbyfayock first needs to authorize it.

@colbyfayock
Copy link
Collaborator

hi @codingis4noobs2 thanks for the PR but this issue was already assigned to someone else inside #29

they're already working on it in a separate PR #31

@codingis4noobs2
Copy link
Contributor Author

@colbyfayock i know, but he hasn't submitted it yet that's why i made a pull request 🙏

@colbyfayock colbyfayock mentioned this pull request Oct 17, 2022
Closed
11 tasks
@colbyfayock
Copy link
Collaborator

hey @codingis4noobs2 change works, can you please add a quick test for this and we can get it moved in?

you'll need to create a new test file under next-cloudinary/tests/plugins/cropping.spec.js

@codingis4noobs2
Copy link
Contributor Author

@colbyfayock Sure, i'll give it a shot 😀

@vercel
Copy link

vercel bot commented Oct 26, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
next-cloudinary ✅ Ready (Inspect) Visit Preview Oct 27, 2022 at 6:55PM (UTC)

@colbyfayock
Copy link
Collaborator

try using this as an example for writing a test https://github.com/colbyfayock/next-cloudinary/blob/main/next-cloudinary/tests/plugins/raw-transformations.spec.js

additionally note the filename convention

@codingis4noobs2
Copy link
Contributor Author

@colbyfayock pls have a look now!!

@colbyfayock
Copy link
Collaborator

can you try checking out the project locally and running the tests? i have to manually start them each time here...

@codingis4noobs2
Copy link
Contributor Author

@colbyfayock ig there are no instructions for running this locally, if you could provide it, It would be great

@colbyfayock
Copy link
Collaborator

  • check out the project
  • run yarn install at the root of the project
  • navigate into next-cloudinary
  • run yarn test

@codingis4noobs2
Copy link
Contributor Author

@colbyfayock ok thx 😀

@codingis4noobs2
Copy link
Contributor Author

It will work now :)

@colbyfayock
Copy link
Collaborator

awesome 💪 thanks for the patience. i gtta update the contributing / working locally docs

@colbyfayock
Copy link
Collaborator

thanks @codingis4noobs2 nice work

email me at [email protected] where i'll send you a form to claim for free swag https://spacejelly.dev/hacktoberfest/

@colbyfayock
Copy link
Collaborator

@all-contributors please add @codingis4noobs2 for code, test

@allcontributors allcontributors bot mentioned this pull request Oct 27, 2022
Merged
@colbyfayock colbyfayock merged commit 14c6cd7 into cloudinary-community:main Oct 27, 2022
@allcontributors
Copy link
Contributor

@colbyfayock

I've put up a pull request to add @codingis4noobs2! 🎉

colbyfayock pushed a commit that referenced this pull request Oct 27, 2022
@allcontributors
docs: add codingis4noobs2 as a contributor for code, and test (#48)
e76e644 
Adds @codingis4noobs2 as a contributor for code, test.

This was requested by colbyfayock [in this
comment](#32 (comment))

[skip ci]

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Oct 27, 2022
@semantic-release-bot
chore(release): 0.3.0 [skip ci]
80942f7 
# [0.3.0](v0.2.0...v0.3.0) (2022-10-27)

### Bug Fixes

* Fix "gravity" is read-only ([#32](#32)) ([14c6cd7](14c6cd7))

### Features

* CldOgImage ([#30](#30)) ([4aa5ff7](4aa5ff7))
@github-actions
Copy link

🎉 This PR is included in version 0.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

cham74 added a commit to cham74/next-image-delivery that referenced this pull request Dec 23, 2023
@cham74 @allcontributors
docs: add codingis4noobs2 as a contributor for code, and test (#48)
4b6d052 
Adds @codingis4noobs2 as a contributor for code, test.

This was requested by colbyfayock [in this
comment](cloudinary-community/next-cloudinary#32 (comment))

[skip ci]

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
cham74 added a commit to cham74/next-image-delivery that referenced this pull request Dec 23, 2023
@cham74
chore(release): 0.3.0 [skip ci]
d72f639 
# [0.3.0](cloudinary-community/next-cloudinary@v0.2.0...v0.3.0) (2022-10-27)

### Bug Fixes

* Fix "gravity" is read-only ([#32](cloudinary-community/next-cloudinary#32)) ([14c6cd7](cloudinary-community/next-cloudinary@14c6cd7))

### Features

* CldOgImage ([#30](cloudinary-community/next-cloudinary#30)) ([4aa5ff7](cloudinary-community/next-cloudinary@4aa5ff7))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codingis4noobs2 @colbyfayock