Type error when combining catchall and array

[chaoran-chen]

Hi everyone. Thank you very much for the great work on zod!

I am getting an error with the following code:

const team = z
    .object({
        members: z.array(z.object({
            name: z.string(),
        })),
    })
    .catchall(z.array(z.string()));
type Team = z.infer<typeof team>;

const t1: Team = {
    members: [
        { name: 'Alice' },
    ],
    aliases: ['a', 'b'],
};

The error message is:

TS2322: Type
  {
    members: {
      name: string;
    }[];
    aliases: string[];
  }
is not assignable to type
objectOutputType<{
  members: ZodArray<ZodObject<{
      name: ZodString;
    }, 'strip', ZodTypeAny, {
      name: string;
    }, {
      name: string;
    }>, 'many'>;
  },
  ZodArray<ZodString, 'many'>,
  'strip'
>

Type
  {
    members: {
      name: string;
    }[];
    aliases: string[];
  }
is not assignable to type
{ [k: string]: string[]; }

Property members is incompatible with index signature.
Type { name: string; }[] is not assignable to type string[]
Type { name: string; } is not assignable to type string

It seems to be a bug to me - or is catchall() simply not designed to be used this way?

(I'd love to receive suggestions for a workaround.)

[JacobWeisenburger]

I have confirmed this bug and here is a more simplified example based on the example in the docs.

https://github.com/colinhacks/zod#catchall

const personSchema = z.object( { name: z.string() } ).catchall( z.number() )
type Person = z.infer<typeof personSchema>
// type Person = {
//     name: string
// } & {
//     [ k: string ]: number
// }

const bobDylan: Person = {
//    ^^^^^^^^
//    Property 'name' is incompatible with index signature.
//    Type 'string' is not assignable to type 'number'.
    name: 'bob dylan',
    validExtraKey: 61,
}

[tommy-mitchell]

I believe this is due to microsoft/TypeScript#17867, not a fault with zod.

[colinhacks]

Unfortunately .catchall() is a bit of a footgun in this way. Zod treats it like a "fallback" for unrecognized keys but TypeScript requires all explicitly defined keys to conform.