cli fails to write to stdout

[kemlath]

icalendar.version = '4.1.0'
python3.8 on ubuntu 20.04

Running "icalendar view file.ics" throws a TypeError: write() argument must be str, not bytes in

the problem is in main() in cli.py

subparser.add_argument( '-o', dest='output_handle', metavar='OUTPUT', type=argparse.FileType('w'), default=sys.stdout, help='output file (default=<stdout>)')

this, per default passes sys.stdout as output_handle in def view(input_handle, output_handle): which fails when bytes are written to it instead of a str during output_handle.write(_template.format(....).encode('utf-8')

As long as argparse.FileType does not properly recognize binary mode strings (e.g. 'wb') a possible fix would be to default to sys.stdout.buffer instead of sys.stdout

[niccokunzmann]

@kemlath Thanks for reporting this! Since you know how to fix this, would you like to create a pull request?
Also, personally, I do like tests to make sure we do not break your change in the future. Is there a way we could test this? I guess so..

Does this only happen with a specific ICS file or with all of them? Can you attach file.ics?

[kemlath]

I'll fork the repo and create a pull request.
There are a few more issues with the cli that came up since then, I'll fix em all and create a pull request.

Really the cli should fail all the time under python3 independent on what you write to sys.stdout as long as you encode it to bytes.

[kemlath]

I just found out that the version of icalendar I got from pypi is version '4.1.0' whereas the current master branch is version 5.0x and has a rather different cli.py which no longer has the above described problem.

Sorry about the confusion

[niccokunzmann]

This calls for creating a new release #429.

[niccokunzmann]

The new version is released. v5.0.0