Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockchain network compatibility accross libp2p protocols #580

Open
da-kami opened this issue Jun 21, 2021 · 0 comments
Open

Blockchain network compatibility accross libp2p protocols #580

da-kami opened this issue Jun 21, 2021 · 0 comments

Comments

@da-kami
Copy link
Member

da-kami commented Jun 21, 2021

Currently it can happen that swap CLI user send BTC to a mainnet swap CLI, but the swap is rejected because the ASB runs on testnet. The BTC then sits in the swap CLI wallet until the user finds a mainnet ASB to swap with.
In the future this problem will be mitigated by implementing #513
Nevertheless, the blockchain network should be ensured for each libp2p protocol.

As discussed here #492 we should have a more complete way to ensure that both the swap CLI and the ASB are on the same network prior to a swap.
Instead of the check against the network in the spot price protocol all protocols (quote, spot price, execution setup, transfer proof, encsig) should have a blockchain network identifier, and messages on an incompatible network should be refused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant