Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBUnit test maintenance #32

Open
mbollmann opened this issue Aug 13, 2015 · 3 comments
Open

DBUnit test maintenance #32

mbollmann opened this issue Aug 13, 2015 · 3 comments

Comments

@mbollmann
Copy link
Member

Originally reported by: Marcel Bollmann (Bitbucket: mbollmann, GitHub: mbollmann)


PHPUnit tests involving the database are currently using their own separate database creation scripts (in tests/data/). This is a nightmare to maintain, and the scripts are most likely out-of-date already, meaning we test against an outdated version of the database schema.

Isn't it possible to use the db/coradb.sql script for this purpose?

I know one reason for the separation is that there are two different DB creation scripts, most notably one which uses MyISAM instead of InnoDB and (therefore) doesn't consider foreign key checks. Still, can't this script maybe be derived automatically from the main db/coradb.sql one?


@mbollmann
Copy link
Member Author

Original comment by Marcel Bollmann (Bitbucket: mbollmann, GitHub: mbollmann):


Make TagsetAccessor tests use the new fixture (re issue #29)

@mbollmann
Copy link
Member Author

Original comment by Marcel Bollmann (Bitbucket: mbollmann, GitHub: mbollmann):


Add new DB test fixture (re issue #29)

The new fixture uses the repo's main coradb.sql schema, helping it stay
up-to-date, contains completely new data, and includes the data's source
files as well as instructions how to modify and update it.

@mbollmann
Copy link
Member Author

Original comment by Marcel Bollmann (Bitbucket: mbollmann, GitHub: mbollmann):


Make DocumentAccessor tests use the new fixture (re issue #29)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant