Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for GPUArraysCore to 0.2, (keep existing compat) #443

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the GPUArraysCore package from 0.1 to 0.1, 0.2.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@willtebbutt willtebbutt force-pushed the compathelper/new_version/2025-01-10-00-05-23-486-01947385523 branch from 5678000 to 60f3e87 Compare January 10, 2025 00:05
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Copy link
Contributor Author

Performance Ratio:
Ratio of time to compute gradient and time to compute function.
Warning: results are very approximate! See here for more context.

┌────────────────────────────┬──────────┬─────────┬─────────────┬─────────┐
│                      Label │ Mooncake │  Zygote │ ReverseDiff │  Enzyme │
│                     String │   String │  String │      String │  String │
├────────────────────────────┼──────────┼─────────┼─────────────┼─────────┤
│                   sum_1000 │     83.0 │     1.1 │        5.61 │    8.11 │
│                  _sum_1000 │     6.97 │  1410.0 │        34.0 │    1.09 │
│               sum_sin_1000 │     2.26 │     1.7 │        10.8 │    1.99 │
│              _sum_sin_1000 │     2.68 │   256.0 │        13.5 │    2.45 │
│                   kron_sum │     66.5 │    3.59 │       208.0 │    7.88 │
│              kron_view_sum │     20.8 │    3.35 │        87.1 │    34.0 │
│      naive_map_sin_cos_exp │     2.53 │ missing │        7.17 │    2.34 │
│            map_sin_cos_exp │     2.75 │    1.54 │        6.14 │    2.92 │
│      broadcast_sin_cos_exp │     2.56 │    2.26 │        1.46 │    2.29 │
│                 simple_mlp │     7.61 │    2.91 │        11.5 │     3.6 │
│                     gp_lml │     12.8 │    10.6 │     missing │    9.62 │
│ turing_broadcast_benchmark │     3.18 │ missing │        25.8 │ missing │
│         large_single_block │     4.42 │  4780.0 │        31.2 │    2.18 │
└────────────────────────────┴──────────┴─────────┴─────────────┴─────────┘

@willtebbutt
Copy link
Member

This actually looks fine -- NNlib doesn't appear to be compatible with 0.2.0 yet, but it appears to be the case that everything else currently works. I'm going to merge this.

@willtebbutt willtebbutt merged commit b847aec into main Jan 10, 2025
72 checks passed
@willtebbutt willtebbutt deleted the compathelper/new_version/2025-01-10-00-05-23-486-01947385523 branch January 10, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant