Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support OUTPUT_QUIET and ERROR_QUIET in conan_cmake_install #312

Closed
RalfBielig opened this issue Feb 25, 2021 · 3 comments · Fixed by #313
Closed

support OUTPUT_QUIET and ERROR_QUIET in conan_cmake_install #312

RalfBielig opened this issue Feb 25, 2021 · 3 comments · Fixed by #313

Comments

@RalfBielig
Copy link

problem:

  • line 534 option OUTPUT_QUIET is missing
  • would be nice to add ERROR_QUIET as well

possible solution:

see:

if(ARGS_OUTPUT_QUIET)

replace:

    if(ARGS_OUTPUT_QUIET)
        execute_process(COMMAND ${CONAN_CMD} ${install_args}
                        RESULT_VARIABLE return_code
                        OUTPUT_VARIABLE conan_output
                        ERROR_VARIABLE conan_output
                        WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR})
    else()
        execute_process(COMMAND ${CONAN_CMD} ${install_args}
                        RESULT_VARIABLE return_code
                        WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR})
    endif()

by:

    if(ARGS_OUTPUT_QUIET)
      set(OUTPUT_OPT OUTPUT_QUIET)
    endif()
    if(ARGS_ERROR_QUIET)
      set(ERROR_OPT ERROR_QUIET)
    endif()
    execute_process(COMMAND ${CONAN_CMD} ${install_args}
                    RESULT_VARIABLE return_code
                    ${OUTPUT_OPT}
                    ${ERROR_OPT}
                    WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR})
@czoido
Copy link
Contributor

czoido commented Feb 25, 2021

Hi @RalfBielig,
Thanks a lot for reporting and suggesting the fix, I'll add this for 0.16.1 milestone.

@czoido
Copy link
Contributor

czoido commented Feb 25, 2021

Closed by: #313

@czoido czoido closed this as completed Feb 25, 2021
@czoido
Copy link
Contributor

czoido commented Feb 25, 2021

Version 0.16.1 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants