[Windows] Macro _conan_detect_build_type doesnt work with Visual Studio IDE

[Sneder89]

Hello everybody!

when I invoke conan_cmake_autodetect with Visual Studio IDE, the function returns inside the macro _conan_detect_build_type an error message because CMAKE_BUILD_TYPE is not defined. Multi Configuration IDE's like VS or XCode doesn't set the Variable CMAKE_BUILD_TYPE but CMAKE_CONFIGURATION_TYPES.

A solution could be that the Variable CMAKE_CONFIGURATION_TYPES is getting evaluated too after CMAKE_BUILD_TYPE and the corresponding settings are getting adapted.

[Nekto89]

I have the same issue. Had to switch to conan_cmake_run

[czoido]

Hi @Sneder89, @Nekto89,
Thanks a lot for reporting the issue, I have reproduced it. We'll try to fix this as soon as possible.

[czoido]

Hi @Sneder89, @Nekto89

Having a more close look at the issue, I think this is how it should work and the CMAKE_CONFIGURATION_TYPES and CMAKE_BUILD_TYPE should be handled from the consumer CMakelists.txt.
In the old flow using conan_cmake_run for Multi Configuration generators would call several times to conan install but as now we are decoupling and separating this behaviours and make it more aligned with conan commands calls we can't handle this from the inside of conan.cmake.
I have added a test to check this works: https://github.com/conan-io/cmake-conan/pull/325/files#diff-f455f302936271d755f6892d443786094d2607b505ff180ca817cb9eeabe1e5eR941-R964
Will this help to solve the problem?

[Sneder89]

Hi @czoido,

this helps and solves my problem. But I agree that its complicated to have manually set CMAKE_BUILD_TYPE to use the conan_settings_autodetect function.

[czoido]

Hi @Sneder89,
I have made some changes so that conan_cmake_autodetect cane be called with the BUILD_TYPE argument so it's more explicit.