Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC version update #646

Closed
sersoftin opened this issue Jun 6, 2024 · 6 comments
Closed

MSVC version update #646

sersoftin opened this issue Jun 6, 2024 · 6 comments
Assignees

Comments

@sersoftin
Copy link

The Microsoft compiler has been updated and is no longer able to run conan install from conan.cmake.
Please fix this for cmake wrapper 0.18.1.

@memsharded memsharded self-assigned this Jun 6, 2024
@memsharded
Copy link
Member

Hi @sersoftin

Thanks for your report.

Please check the warnings and readmes in the repo. Conan 1 is no longer the recommended version, and cmake-conan version 0.18.1 is for Conan 1. Conan 2 was released 16 months ago already, and the recommended version is the one using CMake providers, that has already been updated.

In any case, I think the fix you are looking for is the one in #643, which has been merged to develop branch. There are no new releases planned for Conan 1 cmake-conan, so you might try to use it from develop branch instead.

@sersoftin
Copy link
Author

@memsharded Thanks.

@tbeu
Copy link

tbeu commented Jun 11, 2024

Same issue here: https://github.com/tbeu/matio/actions/runs/9456015260/job/26047052662?pr=249#step:5:40

Can you please create a new release - either C1 or C2 - where the issue is fixed. Thanks.

@memsharded
Copy link
Member

The develop2 branch is considered stable and good enough for production, it can be used in projects (it is already being used by the CLion integration).

The recommended approach is to download a copy an put it in the project, so it can be used easily just by cloning the project.

Conan 1 will not get more releases for cmake-conan. For Conan 2 there will be a release, but not immediately, please use the develop2 in the meantime.

@tbeu
Copy link

tbeu commented Jun 12, 2024

Thanks for the reply.

The recommended approach is to download a copy an put it in the project, so it can be used easily just by cloning the project.

I already did and was able to patch manually.

@memsharded
Copy link
Member

Sounds good, thanks for the feedback.

I am closing this ticket as resolved, keep tuned to the repo for the first numbered releases with the Conan 2 cmake-conan integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants