Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spdlog/1.6.1] : CMake Config files not available #1970

Closed
piponazo opened this issue Jun 19, 2020 · 4 comments
Closed

[spdlog/1.6.1] : CMake Config files not available #1970

piponazo opened this issue Jun 19, 2020 · 4 comments
Assignees
Labels
question Further information is requested

Comments

@piponazo
Copy link

Package and Environment Details (include every applicable attribute)

  • Package Name/Version: spdlog/1.6.1
  • Operating System+version: Windows 10 (But it will happen on any OS)
  • Compiler+version: MSVC 2019
  • Conan version: conan 1.23.0
  • Python version: Python 3.8.1

Conan profile

$ conan profile show vs16Debug
Configuration for profile vs16Debug:

[settings]
os=Windows
os_build=Windows
arch=x86_64
arch_build=x86_64
compiler=Visual Studio
compiler.version=16
compiler.runtime=MDd
build_type=Debug
[options]
[build_requires]
[env]```


### Steps to reproduce (Include if Applicable)
Consume spdlog/1.6.1 with the conan client. Then try to consume the **spdlog** from other project being configured with CMake, as it is advised here:

https://github.com/gabime/spdlog/blob/v1.x/example/CMakeLists.txt

When running CMake, I have the following error:
```bash
CMake Error at cmake/findDependencies.cmake:8 (find_package):
  By not providing "Findspdlog.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "spdlog", but
  CMake did not find one.

  Could not find a package configuration file provided by "spdlog" with any
  of the following names:

    spdlogConfig.cmake
    spdlog-config.cmake

More details

The problem seems to be that in the spdlog conan recipe, some directories are removed in the package step (and one of these folders is the CMake one).

https://github.com/conan-io/conan-center-index/blob/master/recipes/spdlog/all/conanfile.py

I do not understand why this folder is removed, when it is a valuable resource being installed in spdlog:

https://github.com/gabime/spdlog/blob/22a169bc319ac06948e7ee0be6b9b0ac81386604/CMakeLists.txt#L274-L324

@piponazo piponazo added the bug Something isn't working label Jun 19, 2020
@uilianries uilianries added question Further information is requested and removed bug Something isn't working labels Jun 19, 2020
@uilianries uilianries self-assigned this Jun 19, 2020
@uilianries
Copy link
Member

Hi @piponazo !

Please, read here to understand why they are not packaged.

As alternative, you should use cmake_find_package generator. It will generate Findxxx.cmake. If it doesn't work, please, open an issue reporting, because that generator is the way, so we should fix the recipe for any problem.

Regards.

@Croydon
Copy link
Contributor

Croydon commented Oct 27, 2020

@piponazo If you have further questions, please ask them.

For now I guess we can close this one

@piponazo
Copy link
Author

Hi, sorry for the late response, somehow I forgot about this issue.

I think I understood the issue, you can close it. Thanks for the feedback.

Just for future reference, the link provided by @uilianries is not valid anymore (in case you want to fix it 😉 )

@Croydon
Copy link
Contributor

Croydon commented Oct 27, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants