wil: correct package_info and msvc version #17021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
review mistakes from #16701 (comment)
This was referenced Apr 13, 2023
Merged
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline (informative, not required for merge) ✔️
All green in build 1 (
|
|
@prince-chrismc please, avoid creating custom branches from CCI repo directly and prefer your fork instead, it starts new CI jobs for each new branch 😄 |
|
Whoops! sorry, that was an accident 👾 good catch did not even see it |
SSE4
approved these changes
Apr 21, 2023
SpaceIm
reviewed
Apr 21, 2023
| def package_id(self): | ||
| self.info.clear() | ||
| self.info.clear() # same package ID for any package |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
review mistakes from #16701 (comment)
Specify library name and version: lib/1.0