Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wt: move boost options checks in validate() + bump deps + slightly improve deps handling #4798

Merged
merged 3 commits into from
Mar 9, 2021

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Mar 5, 2021

Specify library name and version: lib/1.0

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

The all dependency handling in upstream build files seems to be fragile, I don't trust it at all.

@conan-center-bot
Copy link
Collaborator

Failure in build 1 (11cec001404d98b7ec8c6ac006ba00dc7f3747b7):

  • wt/4.3.1@:
    An unexpected error happened and has been reported

  • wt/4.4.0@:
    An unexpected error happened and has been reported

  • wt/4.5.0@:
    CI failed to create some packages (All logs)

    Logs for packageID 5df3f70e940ee298fc0b61c78613fbae30b9814d:
    [settings]
    arch=x86_64
    arch_build=x86_64
    build_type=Release
    compiler=Visual Studio
    compiler.runtime=MT
    compiler.version=16
    os=Windows
    os_build=Windows
    [options]
    wt:shared=True
    
      New Boost version may have incorrect or missing dependencies and imported
      targets
    Call Stack (most recent call first):
      C:/Program Files/CMake/share/cmake-3.16/Modules/FindBoost.cmake:1283 (_Boost_COMPONENT_DEPENDENCIES)
      C:/Program Files/CMake/share/cmake-3.16/Modules/FindBoost.cmake:1921 (_Boost_MISSING_DEPENDENCIES)
      source_subfolder/cmake/WtFindBoost.txt:92 (FIND_PACKAGE)
      source_subfolder/CMakeLists.txt:241 (INCLUDE)
    
    
    CMake Warning at C:/Program Files/CMake/share/cmake-3.16/Modules/FindBoost.cmake:1161 (message):
      New Boost version may have incorrect or missing dependencies and imported
      targets
    Call Stack (most recent call first):
      C:/Program Files/CMake/share/cmake-3.16/Modules/FindBoost.cmake:1283 (_Boost_COMPONENT_DEPENDENCIES)
      C:/Program Files/CMake/share/cmake-3.16/Modules/FindBoost.cmake:1921 (_Boost_MISSING_DEPENDENCIES)
      source_subfolder/cmake/WtFindBoost.txt:92 (FIND_PACKAGE)
      source_subfolder/CMakeLists.txt:241 (INCLUDE)
    
    
    ** Enabling multi threading.
    ** Not building libwttest
    ** Disabling PDF support (WPdfImage, WPdfRenderer): requires libharu.
    ** Disabling server-side opengl rendering for WGLWidget: requires gl, glew and WRasterImage (GraphicsMagick or skia).
    ** Enabling advanced font support using DirectWrite
    ** Wt::Dbo: building SQLite3 backend.
    ** Wt::Dbo: building Postgres backend.
    ** Wt::Dbo: not building Firebird backend.
    ** Wt::Dbo: building MySQL backend.
    ** Wt::Dbo: not building Microsoft SQL Server backend.
    ** Enabling ISAPI.
    ** Disabling FastCGI connector.
    ** Enabling built-in httpd.
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        CMAKE_EXPORT_NO_PACKAGE_REGISTRY
        CMAKE_INSTALL_BINDIR
        CMAKE_INSTALL_DATAROOTDIR
        CMAKE_INSTALL_INCLUDEDIR
        CMAKE_INSTALL_LIBDIR
        CMAKE_INSTALL_LIBEXECDIR
        CMAKE_INSTALL_OLDINCLUDEDIR
        CMAKE_INSTALL_SBINDIR
    
    
    wt/4.5.0: ERROR: Package '5df3f70e940ee298fc0b61c78613fbae30b9814d' build failed
    wt/4.5.0: WARN: Build folder C:\J\w\BuildSingleReference@3\.conan\data\wt\4.5.0\_\_\build\5df3f70e940ee298fc0b61c78613fbae30b9814d
    ERROR: wt/4.5.0: Error in build() method, line 208
    	cmake.build()
    	ConanException: Error 1 while executing cmake --build C:\J\w\BuildSingleReference@3\.conan\data\wt\4.5.0\_\_\build\5df3f70e940ee298fc0b61c78613fbae30b9814d\build_subfolder --config Release -- /m:16 /verbosity:minimal
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@conan-center-bot
Copy link
Collaborator

Failure in build 3 (11cec001404d98b7ec8c6ac006ba00dc7f3747b7):

  • wt/4.3.1@:
    CI failed to create some packages (All logs)

    Logs for packageID c3c3a4e6941f88ad03663f431cdbb40e2a31a4ef:
    [settings]
    arch=x86_64
    arch_build=x86_64
    build_type=Debug
    compiler=Visual Studio
    compiler.runtime=MTd
    compiler.version=16
    os=Windows
    os_build=Windows
    [options]
    wt:shared=True
    
      New Boost version may have incorrect or missing dependencies and imported
      targets
    Call Stack (most recent call first):
      C:/Program Files/CMake/share/cmake-3.16/Modules/FindBoost.cmake:1283 (_Boost_COMPONENT_DEPENDENCIES)
      C:/Program Files/CMake/share/cmake-3.16/Modules/FindBoost.cmake:1921 (_Boost_MISSING_DEPENDENCIES)
      source_subfolder/cmake/WtFindBoost.txt:88 (FIND_PACKAGE)
      source_subfolder/CMakeLists.txt:241 (INCLUDE)
    
    
    CMake Warning at C:/Program Files/CMake/share/cmake-3.16/Modules/FindBoost.cmake:1161 (message):
      New Boost version may have incorrect or missing dependencies and imported
      targets
    Call Stack (most recent call first):
      C:/Program Files/CMake/share/cmake-3.16/Modules/FindBoost.cmake:1283 (_Boost_COMPONENT_DEPENDENCIES)
      C:/Program Files/CMake/share/cmake-3.16/Modules/FindBoost.cmake:1921 (_Boost_MISSING_DEPENDENCIES)
      source_subfolder/cmake/WtFindBoost.txt:88 (FIND_PACKAGE)
      source_subfolder/CMakeLists.txt:241 (INCLUDE)
    
    
    ** Enabling multi threading.
    ** Not building libwttest
    ** Disabling PDF support (WPdfImage, WPdfRenderer): requires libharu.
    ** Disabling server-side opengl rendering for WGLWidget: requires gl, glew and WRasterImage (GraphicsMagick or skia).
    ** Enabling advanced font support using DirectWrite
    ** Wt::Dbo: building SQLite3 backend.
    ** Wt::Dbo: building Postgres backend.
    ** Wt::Dbo: not building Firebird backend.
    ** Wt::Dbo: building MySQL backend.
    ** Wt::Dbo: not building Microsoft SQL Server backend.
    ** Enabling ISAPI.
    ** Disabling FastCGI connector.
    ** Enabling built-in httpd.
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        CMAKE_EXPORT_NO_PACKAGE_REGISTRY
        CMAKE_INSTALL_BINDIR
        CMAKE_INSTALL_DATAROOTDIR
        CMAKE_INSTALL_INCLUDEDIR
        CMAKE_INSTALL_LIBDIR
        CMAKE_INSTALL_LIBEXECDIR
        CMAKE_INSTALL_OLDINCLUDEDIR
        CMAKE_INSTALL_SBINDIR
    
    
    wt/4.3.1: ERROR: Package 'c3c3a4e6941f88ad03663f431cdbb40e2a31a4ef' build failed
    wt/4.3.1: WARN: Build folder C:\J\w\BuildSingleReference@2\.conan\data\wt\4.3.1\_\_\build\c3c3a4e6941f88ad03663f431cdbb40e2a31a4ef
    ERROR: wt/4.3.1: Error in build() method, line 208
    	cmake.build()
    	ConanException: Error 1 while executing cmake --build C:\J\w\BuildSingleReference@2\.conan\data\wt\4.3.1\_\_\build\c3c3a4e6941f88ad03663f431cdbb40e2a31a4ef\build_subfolder --config Debug -- /m:16 /verbosity:minimal
    
  • wt/4.5.0@:
    CI failed to create some packages (All logs)

    Logs for packageID 19af5f9149557dc2fdfca42ca74487840dd2ac49:
    [settings]
    arch=x86_64
    arch_build=x86_64
    build_type=Release
    compiler=Visual Studio
    compiler.runtime=MD
    compiler.version=16
    os=Windows
    os_build=Windows
    [options]
    wt:shared=True
    
      New Boost version may have incorrect or missing dependencies and imported
      targets
    Call Stack (most recent call first):
      C:/Program Files/CMake/share/cmake-3.16/Modules/FindBoost.cmake:1283 (_Boost_COMPONENT_DEPENDENCIES)
      C:/Program Files/CMake/share/cmake-3.16/Modules/FindBoost.cmake:1921 (_Boost_MISSING_DEPENDENCIES)
      source_subfolder/cmake/WtFindBoost.txt:92 (FIND_PACKAGE)
      source_subfolder/CMakeLists.txt:241 (INCLUDE)
    
    
    CMake Warning at C:/Program Files/CMake/share/cmake-3.16/Modules/FindBoost.cmake:1161 (message):
      New Boost version may have incorrect or missing dependencies and imported
      targets
    Call Stack (most recent call first):
      C:/Program Files/CMake/share/cmake-3.16/Modules/FindBoost.cmake:1283 (_Boost_COMPONENT_DEPENDENCIES)
      C:/Program Files/CMake/share/cmake-3.16/Modules/FindBoost.cmake:1921 (_Boost_MISSING_DEPENDENCIES)
      source_subfolder/cmake/WtFindBoost.txt:92 (FIND_PACKAGE)
      source_subfolder/CMakeLists.txt:241 (INCLUDE)
    
    
    ** Enabling multi threading.
    ** Not building libwttest
    ** Disabling PDF support (WPdfImage, WPdfRenderer): requires libharu.
    ** Disabling server-side opengl rendering for WGLWidget: requires gl, glew and WRasterImage (GraphicsMagick or skia).
    ** Enabling advanced font support using DirectWrite
    ** Wt::Dbo: building SQLite3 backend.
    ** Wt::Dbo: building Postgres backend.
    ** Wt::Dbo: not building Firebird backend.
    ** Wt::Dbo: building MySQL backend.
    ** Wt::Dbo: not building Microsoft SQL Server backend.
    ** Enabling ISAPI.
    ** Disabling FastCGI connector.
    ** Enabling built-in httpd.
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        CMAKE_EXPORT_NO_PACKAGE_REGISTRY
        CMAKE_INSTALL_BINDIR
        CMAKE_INSTALL_DATAROOTDIR
        CMAKE_INSTALL_INCLUDEDIR
        CMAKE_INSTALL_LIBDIR
        CMAKE_INSTALL_LIBEXECDIR
        CMAKE_INSTALL_OLDINCLUDEDIR
        CMAKE_INSTALL_SBINDIR
    
    
    wt/4.5.0: ERROR: Package '19af5f9149557dc2fdfca42ca74487840dd2ac49' build failed
    wt/4.5.0: WARN: Build folder C:\J\w\BuildSingleReference@4\.conan\data\wt\4.5.0\_\_\build\19af5f9149557dc2fdfca42ca74487840dd2ac49
    ERROR: wt/4.5.0: Error in build() method, line 208
    	cmake.build()
    	ConanException: Error 1 while executing cmake --build C:\J\w\BuildSingleReference@4\.conan\data\wt\4.5.0\_\_\build\19af5f9149557dc2fdfca42ca74487840dd2ac49\build_subfolder --config Release -- /m:16 /verbosity:minimal
    
  • wt/4.4.0@:
    CI failed to create some packages (All logs)

    Logs for packageID c3c3a4e6941f88ad03663f431cdbb40e2a31a4ef:
    [settings]
    arch=x86_64
    arch_build=x86_64
    build_type=Debug
    compiler=Visual Studio
    compiler.runtime=MTd
    compiler.version=16
    os=Windows
    os_build=Windows
    [options]
    wt:shared=True
    
      New Boost version may have incorrect or missing dependencies and imported
      targets
    Call Stack (most recent call first):
      C:/Program Files/CMake/share/cmake-3.16/Modules/FindBoost.cmake:1283 (_Boost_COMPONENT_DEPENDENCIES)
      C:/Program Files/CMake/share/cmake-3.16/Modules/FindBoost.cmake:1921 (_Boost_MISSING_DEPENDENCIES)
      source_subfolder/cmake/WtFindBoost.txt:88 (FIND_PACKAGE)
      source_subfolder/CMakeLists.txt:241 (INCLUDE)
    
    
    CMake Warning at C:/Program Files/CMake/share/cmake-3.16/Modules/FindBoost.cmake:1161 (message):
      New Boost version may have incorrect or missing dependencies and imported
      targets
    Call Stack (most recent call first):
      C:/Program Files/CMake/share/cmake-3.16/Modules/FindBoost.cmake:1283 (_Boost_COMPONENT_DEPENDENCIES)
      C:/Program Files/CMake/share/cmake-3.16/Modules/FindBoost.cmake:1921 (_Boost_MISSING_DEPENDENCIES)
      source_subfolder/cmake/WtFindBoost.txt:88 (FIND_PACKAGE)
      source_subfolder/CMakeLists.txt:241 (INCLUDE)
    
    
    ** Enabling multi threading.
    ** Not building libwttest
    ** Disabling PDF support (WPdfImage, WPdfRenderer): requires libharu.
    ** Disabling server-side opengl rendering for WGLWidget: requires gl, glew and WRasterImage (GraphicsMagick or skia).
    ** Enabling advanced font support using DirectWrite
    ** Wt::Dbo: building SQLite3 backend.
    ** Wt::Dbo: building Postgres backend.
    ** Wt::Dbo: not building Firebird backend.
    ** Wt::Dbo: building MySQL backend.
    ** Wt::Dbo: not building Microsoft SQL Server backend.
    ** Enabling ISAPI.
    ** Disabling FastCGI connector.
    ** Enabling built-in httpd.
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        CMAKE_EXPORT_NO_PACKAGE_REGISTRY
        CMAKE_INSTALL_BINDIR
        CMAKE_INSTALL_DATAROOTDIR
        CMAKE_INSTALL_INCLUDEDIR
        CMAKE_INSTALL_LIBDIR
        CMAKE_INSTALL_LIBEXECDIR
        CMAKE_INSTALL_OLDINCLUDEDIR
        CMAKE_INSTALL_SBINDIR
    
    
    wt/4.4.0: ERROR: Package 'c3c3a4e6941f88ad03663f431cdbb40e2a31a4ef' build failed
    wt/4.4.0: WARN: Build folder C:\J\w\BuildSingleReference@5\.conan\data\wt\4.4.0\_\_\build\c3c3a4e6941f88ad03663f431cdbb40e2a31a4ef
    ERROR: wt/4.4.0: Error in build() method, line 208
    	cmake.build()
    	ConanException: Error 1 while executing cmake --build C:\J\w\BuildSingleReference@5\.conan\data\wt\4.4.0\_\_\build\c3c3a4e6941f88ad03663f431cdbb40e2a31a4ef\build_subfolder --config Debug -- /m:16 /verbosity:minimal
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Mar 7, 2021

Seems to be an issue coming from libmysqlclient and use of std::once_flag. Surprisingly, it fails with Visual Studio 16 shared MTd, but not with Visual Studio 15 shared MTd

@conan-center-bot
Copy link
Collaborator

All green in build 4 (11cec001404d98b7ec8c6ac006ba00dc7f3747b7):

  • wt/4.3.1@:
    All packages built successfully! (All logs)

  • wt/4.4.0@:
    All packages built successfully! (All logs)

  • wt/4.5.0@:
    All packages built successfully! (All logs)

@SSE4 SSE4 requested a review from uilianries March 9, 2021 05:55
@conan-center-bot conan-center-bot merged commit 86d39bf into conan-io:master Mar 9, 2021
@SpaceIm SpaceIm deleted the fix/wt-validate branch March 9, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants