Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/nsync #6085
Feature/nsync #6085
Changes from all commits
5f1419d
99b049c
89c0a21
5b138bc
87ed6a8
49efd36
25f9752
0b171a8
90345d4
d5d3786
0e85191
ae8c9b3
8a7107c
8410cac
93121cd
d87aa70
0c6f4a7
2c88b10
5f45f40
3ef05d4
8e913da
db3df8c
b536769
a3db04d
411b55a
d088f49
aa8f759
26c62b8
17bd7b2
4180c78
0f213ec
b48c151
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd apply this change regardless of the OS and build type, even if only makes sense there.
Also keep in mind you're removing the
COMPONENT
, I don't know the implications of this in this particular case.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per documentation in https://cmake.org/cmake/help/latest/command/install.html:
Because we don't perform component-specific installation probably this is not the case for us.
As another solution, I think we can safely add
COMPONENT RuntimeLibraries