Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fork canbus library and implement as git submodule #20

Open
5 tasks
rickyelopez opened this issue Sep 2, 2020 · 0 comments
Open
5 tasks

fork canbus library and implement as git submodule #20

rickyelopez opened this issue Sep 2, 2020 · 0 comments
Labels
enhancement New feature or request optimization Optimizing existing code requires cage Task requires access to the cage or resources in the cage

Comments

@rickyelopez
Copy link
Member

rickyelopez commented Sep 2, 2020

I used this library to implement the MCP2515. I had to modify it slightly to get it to work for our use case. Thus, it hasn't been updated from source in literally years. It would be nice to rebase to the new code and validate that everything still works. If the modification that I originally made is still necessary, the repo should be forked to our org and modified. Either way it should be re-implemented using a git submodule so that we can keep it up to date. It would also be nice to see whether we can just do away with this library and use the Seeed library (here) instead

  • independently (i.e. not using the steering wheel, lest we seriously break something) validate whether the un-modified seeed codebase works for can communication between the motec and stm32/esp32.
    • if it doesn't work, make it work
    • re-implement the modification I had originally made (talk to @rickyelopez about this if necessary)
  • Fork the the adafruit repo into our organization and modify as necessary
  • Re-implement into this repo as a git submodule
@rickyelopez rickyelopez added enhancement New feature or request optimization Optimizing existing code requires cage Task requires access to the cage or resources in the cage labels Sep 2, 2020
@rickyelopez rickyelopez changed the title fork seeed canbus library and implement as git submodule fork canbus library and implement as git submodule Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request optimization Optimizing existing code requires cage Task requires access to the cage or resources in the cage
Projects
None yet
Development

No branches or pull requests

1 participant