Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CGAL to 4.14.1 #6

Merged
merged 6 commits into from
Oct 25, 2019
Merged

Update CGAL to 4.14.1 #6

merged 6 commits into from
Oct 25, 2019

Conversation

Michsior14
Copy link
Contributor

@Michsior14 Michsior14 commented Oct 25, 2019

Updates to the bugfixed version of CGAL 4.14.

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • license_file entry is missing, but is expected.

@Michsior14
Copy link
Contributor Author

@conda-forge-admin, please rerender

@Michsior14
Copy link
Contributor Author

I have no idea why the build failed on osx and win. Looks like some kind of pipeline problem?

@tadeu
Copy link
Member

tadeu commented Oct 25, 2019

On Windows it looks like %CMAKE_GENERATOR% can't be used on Azure, the workaround is to use NMake:

conda-forge/conda-forge.github.io#703 (comment)

I'll try changing that

@tadeu
Copy link
Member

tadeu commented Oct 25, 2019

About macOS, I have no idea why conda isn't able to extract a simple .zip file:

libarchive.exception.ArchiveError: Could not open CGAL-4.14.1 (errno=14, retcode=-30, archive_p=140209583138080)

to try to check if macOS archive problem was because of this
@tadeu tadeu merged commit ee227e8 into conda-forge:master Oct 25, 2019
@tadeu
Copy link
Member

tadeu commented Oct 25, 2019

Thanks @Michsior14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants