Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static libraries included #134

Closed
hmaarrfk opened this issue Jan 10, 2022 · 7 comments
Closed

static libraries included #134

hmaarrfk opened this issue Jan 10, 2022 · 7 comments

Comments

@hmaarrfk
Copy link
Contributor

I was auditing this recipe and noticed that static libraries are included.

Is any maintainer actively using them? Or do we think it would be safe to simply remove the static libraries from the recipe.

It seems to have been built this way for a long time.

@hmaarrfk hmaarrfk changed the title static libraries include static libraries included Jan 10, 2022
@xylar
Copy link
Contributor

xylar commented Jan 11, 2022

@hmaarrfk, this is a great discussion to be had. There are enough different packages that use libnetcdf that it's almost inevitable that some might be using static libraries. I'm not aware of any off the top of my head, though. @ocefpaf, how about you?

@ocefpaf
Copy link
Member

ocefpaf commented Jan 18, 2022

To be honest I do not recall the libs that use the static library. The best course of action would be to do a multiple outputs and create a libnetcdf-static.

@xylar
Copy link
Contributor

xylar commented Jan 18, 2022

Ooh, I like that idea. That way, we could quickly find out which packages need libnetcdf-static but we would have a fix that didn't break them for very long. @hmaarrfk, do you have the time or interest to put in a PR for that purpose? If not, it might not happen all that soon.

@hmaarrfk
Copy link
Contributor Author

Is there a way to get the package name from the build script?

@xylar
Copy link
Contributor

xylar commented Sep 16, 2022

Once this is done, we should do the same for netcdf-fortran.

@dopplershift
Copy link
Member

We stopped building the static library with 4.9.0 (#140). Can this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants