Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant host dependencies #46

Closed
jcarpent opened this issue Jun 30, 2021 · 1 comment
Closed

Redundant host dependencies #46

jcarpent opened this issue Jun 30, 2021 · 1 comment

Comments

@jcarpent
Copy link

Some host dependencies seem redundant in the list:

- libignition-cmake2
- libignition-math6
- libignition-tools1
- libignition-utils1
- urdfdom
- tinyxml2
- console_bridge

It would be nice to make them minimal I would say. Does it go in line with the whole ROS conda spirit?

Best,
Justin

@Tobias-Fischer
Copy link
Contributor

I think all of the dependencies (except for one, see below) are listed in https://github.com/ignitionrobotics/sdformat/blob/sdf11/cmake/SearchForStuff.cmake and are thus direct dependencies of sdformat. Thus I think it would be risky to remove some of the libignition ones (which indeed might be pulled in transitively).

That said, console_bridge does not seem to be needed anymore and we might want to remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants