deploy version 1.2.0 #31
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to re-render for you but ran into some issues, please ping conda-forge/core for further assistance. You can also try re-rendering locally. |
|
@conda-forge/core tried to rerender locally, but can't get current smithy installed Fails: conda create -n conda-smithy python=3.7 conda-smithyP.S.: I know my conda is not on latest version, but |
|
I think this needs to point to the RC branch as well. |
I'm sorry, but what do you mean by that? |
|
We very recently adopted a new policy toward dev/rc releases https://github.com/conda-forge/cfep/blob/master/cfep-05.md We usually do not let rc releases into the master branch (and the main conda-forge channel). |
|
Oh, I see, thanks for the link. I wasn't planning on deploying any RC builds, though, what I usually did was to see if they CI build and tests are OK and then finally only deploy the actual release. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to re-render for you, but it looks like I wasn't able to push to the package_1.2.0 branch of obspy/obspy-feedstock. Did you check the "Allow edits from maintainers" box? |
Uhm.. I don't see that box, neither on this open PR nor when opening a new PR. |
|
Next to your first comment on the right you should have a column with:
|
recipe/meta.yaml
Outdated
| sha256: {{ sha256 }} | ||
|
|
||
| # for RC builds | ||
| channel_targets: | ||
| - conda-forge rc_obspy |
There was a problem hiding this comment.
This has to go into conda_build_config.yaml.
Also note that obspy_rc would be the preferred naming, we have a pending change for that: conda-forge/cfep#3 (comment)
There was a problem hiding this comment.
(see also conda-forge/cfep#21 reflecting the preferred naming)
There was a problem hiding this comment.
Thanks! However, we don't actually intend to merge (and thus deploy) the RCs, I was just making sure the builds look good in CI and we do not have packaging problems. We're expecting to push out the release in the next few days and I'll update this PR with the release zipball.
screenshot
for new PR: screenshot
|
|
Ah, I just checked: For PRs from my personal profile ( |
|
Nice catch @mbargull. In any case, I made a fresh miniconda installation just for rerendering, since in my existing one, I can't update conda anymore it does not finish and installing smithy in a new environment crashes (presumably due to a conda bug that was fixed in a newer version). |
…nda-forge-pinning 2020.01.27
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Rebased and force pushed without the RC label, we don't have a need to deploy the RC build really, and having the test reports sent from CI to our test overview pages at obspy is sufficient. We will only merge this with the build of the final obspy 1.2.0 release when it is ready. |
|
The py27 CI fails with a weird error, apparently the installed executable scripts get executed with a wrong Python interpreter (py3) Is there a way to access the built packages even if they are not deployed (access as artifact on CI job?)? |
No, I don't believe there is (sadly).
Nope, if it were executed with Py3 it wouldn't error out ;). This is a legitimate Py2-related error. The entry point scripts that are created do not |
Oh.. good point. I managed to reproduce it locally, so hopefully I can work around it somehow. |
|
Probably the easiest thing (apart from dropping 2.7 support right away :P) would be to just create an indirection via something like #!/usr/bin/env python
# -*- coding: utf-8 -*-
"""
Print stream information for waveform data in local files.
"""
from __future__ import (absolute_import, division, print_function,
unicode_literals)
from .print import main
main = mainand set the entry point to (Another alternative would be, of course, to not use |
|
There is another failure at https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=115616&view=logs&j=e5cdccbf-4751-5a24-7406-185c9d30d021&t=d66ed8ca-07ff-5419-c5d1-5e21fa500bb4&l=4890: judging by the looks of it, this comes from https://github.com/obspy/obspy/blob/1.2.0rc1/obspy/clients/filesystem/tests/test_sds.py#L214-L225 and might be due to the |
|
Thanks a lot for the tip @mbargull, that indirection is indeed probably the easiest solution. |
see conda-forge/obspy-feedstock#31 (comment) Just work around some weird erroneous SyntaxError check due to a module being named "print.py", unfortunately
|
Oh, apologies, I've misread before and thought the But the solution is even easier than that: The path has been shortened to ye old 8.3 scheme with à la -<title>SDS Report [\w:/\\]*?[/\\]obspy-sdstest-[\w]*</title>
+<title>SDS Report [\w:/\\~]*?[/\\]obspy-sdstest-[\w]*</title> |
|
Thanks @mbargull, I played around locally with adding a tilde but with all the escaping going on I couldn't confirm it was just the |
|
@ThomasLecocq any idea regarding the failing console script calls? Wait.. Windows doesn't use dash for command line options but slashes, right? CC @barsch v1.1.1 build on Windows also had problems calling those scripts but still passed somehow btw.. https://ci.appveyor.com/project/conda-forge/obspy-feedstock/builds/26476698/job/xkj5d3xqksss7j8j#L6219 |
…that works" This reverts commit 8c31343.
somehow it doesn't seem to find the command line scripts in path
|
OK build looks good. Do not merge will update with final release when it's ready. |
|
@megies anything I can do / help here ? |
|
My bad, didn't update the static file link for the RC build here @ThomasLecocq |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)DO NOT MERGE YET -- TESTING BUILD WITH RELEASE CANDIDATES