-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Included tests make the package large #117
Comments
Unless there's a simple way to pass arguments to Thanks for the report! |
Yeah, i've been trying to think of a good name of this extra package. For the conda-package, I gave up on finding a solution: The tests were never run prior to adding that flag. |
my issue wit hthe I think maybe |
TBH, I don't think that's an issue. And if upstream ever were to publish something like that, we could build some deprecation for our output. The scipy-feedstock would similarly take |
Ok. The tests name sounds fine |
I guess we are at the point where a PR would be accepted. |
Solution to issue cannot be found in the documentation.
Issue
Recent builds of the
pillow
package, which include the tests and test images, weigh in at ~45 MB. Without the tests included, the package occupies less than 1 MB of space. The tests don't get installed into the environment, so the main effect is a bigger download and more space occupied in the package cache. Since nobody is likely to want to run the tests themselves from the packaged tarball, I think that shrinking the package back down to its previous size would be a big benefit (particularly sincepillow
is a dependency ofmatplotlib-base
, which I assume many people will install).Conda-build has a
--no-copy-test-source-files
which would allow the tests to still run in the feedstock and prevent them from ending up in the package, but I don't know if there is a way to use that. Another possible solution could be to create a separate output (e.g.pillow-tests
) and run the tests through that. That way they would still be available in a package, but the majority of users would not have to use the extra space.Installed packages
Environment info
The text was updated successfully, but these errors were encountered: