-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gala recipe #1633
Add gala recipe #1633
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
- python | ||
- setuptools | ||
- cython | ||
- numpy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jni b/c gala relies on numpy
's ABI you need to specify numpy x.x
here and below to bake the numpy
build string and ensure the same numpy
version used in the build will be installed at run time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right. Can I specify a numpy range, numpy>=1.11? So that it still gets built correctly when 1.12 comes out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I specify a numpy range, numpy>=1.11?
You can specify it twice when there is a numpy version limitation, like it only works > 1.10, for example.
So that it still gets built correctly when 1.12 comes out?
No need in that case b/c the numpy matrix is defined automatically by conda-forge. Right now our lower limit is numpy 1.10.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry can you clarify what you meant with "specify it twice"? What's the spec?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example below in the diff. Hope that clarifies it.
|
This is likely a mistake in your
|
So if there are some errors that are going to require some iteration on the repo, would suggestion switching to cloning it from the git repo. We will have to switch it back later, but this allows us to keep progressing and then you can make a patch release once we have everything working. |
- numpy x.x | ||
run: | ||
- python | ||
- numpy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should also be numpy x.x
- python | ||
- setuptools | ||
- cython | ||
- numpy x.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To further restrict numpy
one can tweak this as follows.
- numpy x.x
- numpy >=1.7
This would then be repeated in run
too.
Woot! Now that I've got my first successful build with Cython deps, I have some questions:
|
|
As @patricksnape mentioned There is a conda-forge enhancement proposal which lays out a plan for making and labeling pre-releases/rc/beta/alpha/etc conda packages which may be of interest. |
Sure that can be done. To respond to others more generally, the point of my asking @jni to try this is so that we can fix some packaging issues that are unique to PyPI/conda-forge. The best place to fix them is here. Now I'm not suggesting that we package some untagged release. On the contrary, I'm suggesting we try iron out these package issues first before we get hung up on the details of how to get this released. Once they are resolved it would be good if @jni is able to either make a new patch release with these fixes or include patches for the near term to work around these issues as has been done before. This hardly something unique to this case and we have occasionally let people do this of their own accord before. |
Hi everyone! Thanks for the responses. My own below:
|
Sure, the suggestion was given only in response to hearing there were compilation issues. As it builds fine now, it seems hardly necessary. Hope that makes sense. |
Thanks @jni. |
Probably worth noting that gala is on conda-forge in this feedstock. 😉 |
Also forgot to cc @stuarteberg . Sorry about that. |
Hi all! Here's my second recipe. This one has a bunch of Cython to build, so fingers crossed that things go smoothly! Thanks!