Support ability to include dependencies of whitelist (#22) #42
+214
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good; I'll take the time though and will run this locally to better understand the change. Thus the merge might take 1-2 days until it happens. |
|
The biggest gotcha with this feature is that it may pull in more packages than you really want especially if you are mirroring from a large repo. You may need to add more package specs to the whitelist to limit what you get. I can't think of a good way to do that automatically. |
|
Thanks, I stepped a bit through with the debugger to fully understand what it does and it seems reasonable 🚀 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.