Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-ASCII characters in target path might affect package extraction #634

Closed
2 tasks done
jaimergp opened this issue Jan 27, 2023 · 4 comments
Closed
2 tasks done
Labels
os::windows relevant to Windows stale::closed [bot] closed after being marked as stale stale [bot] marked as stale due to inactivity type::bug describes erroneous operation, use severity::* to classify the type

Comments

@jaimergp
Copy link
Contributor

Checklist

  • I added a descriptive title
  • I searched open reports and couldn't find a duplicate

What happened?

Comes from https://conda.discourse.group/t/install-miniconda3-for-windows/169/11

Conclusions from the 1:1 investigations:

  • Latest Miniconda for Windows x64 (as of today) could not get installed in a path with non-ASCII characters. In the reported issue, the Windows username is Ángel.
  • Installation worked better with the "All Users" option (packages were extracted and linked correctly), but it crashed BAD when the uninstaller was supposed to be written. No error dialogue or anything, just a vanished installer after a sub-second flash of a red-cross dialog.
  • If the installation happened into an ASCII compliant path, no errors were reported even in "Just Me" mode. However, this observation was only made after an accidental computer restart.

Conda Info

N/A

Conda Config

N/A

Conda list

N/A

Additional Context

  • The user had attempted several installations with different degrees of success, but they had all failed. This included Miniconda, Anaconda, Mambaforge (which used the current constructor, but also previous versions with old conda-standalones).
  • An old VS Code extension (maybe this one) had apparently installed a CPython into C:\Python and added that to PATH. This is bad practice, but the installer should be able to run regardless. This might not be related, but it's worth investigating, because it might be another issue to fix.

I'm also attaching some of the logs collected during the investigation:

It looks like the problem comes from conda-package-handling and/or libarchive. @dholth Have you seen errors like this during your tests? Check the miniconda logs; mambaforge errors are different, probably because of the previous failed installs leaving .condarc files around... aka #568.

@jaimergp jaimergp added type::bug describes erroneous operation, use severity::* to classify the type os::windows relevant to Windows labels Jan 27, 2023
@dholth
Copy link

dholth commented Jan 27, 2023

These errors xz-5.2.8-h8cc25b3_0\.cph_tmpw8doj7mq\info-xz-5.2.8-h8cc25b3_0.tar.zst would be libarchive-related (conda-package-handling 1.x series) since 2.x doesn't put the .tar.zstin a temporary directory.

I'm not sure where multiprocessing is used, the recent parallel-download-and-extract from 22.11 conda uses threads.

@jaimergp
Copy link
Contributor Author

Most probably conda-standalone. This block:

            with tqdm.tqdm(total=len(flist), leave=False) as t:
                with ProcessPoolExecutor(max_workers=args.num_processors) as executor:
                    for fn, _ in zip(flist, executor.map(api.extract, flist)):
                        t.set_description("Extracting : %s" % os.path.basename(fn))
                        t.update()

@hmaarrfk
Copy link
Contributor

@celliern reported a similar issue in conda-forge/miniforge#484

Copy link

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include:
    - What OS and version you reproduced the issue on
    - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label Sep 10, 2024
@github-actions github-actions bot added the stale::closed [bot] closed after being marked as stale label Oct 10, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2024
@github-project-automation github-project-automation bot moved this to 🏁 Done in 🧭 Planning Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os::windows relevant to Windows stale::closed [bot] closed after being marked as stale stale [bot] marked as stale due to inactivity type::bug describes erroneous operation, use severity::* to classify the type
Projects
Archived in project
Development

No branches or pull requests

3 participants