Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we limit the gas for begin/ end block callbacks? #126

Open
alpe opened this issue Sep 9, 2021 · 1 comment
Open

Should we limit the gas for begin/ end block callbacks? #126

alpe opened this issue Sep 9, 2021 · 1 comment
Labels
M Medium task, 1-3 days work question Further information is requested Requires Information Requires more information. Specify from whom! state_breaking
Milestone
Tgrade - "Post Ma...

Comments

@alpe
Copy link
Contributor

alpe commented Sep 9, 2021

They run with infinite gas.
If we want to limit them, what would be a reasonable value? Any out of gas panic will not be catched and creates a consensus failure
@alpe alpe added the question Further information is requested label Sep 9, 2021
@alpe alpe added the Requires Information Requires more information. Specify from whom! label May 10, 2022
@alpe alpe added this to the Tgrade - "Post Mainnet" milestone May 10, 2022
@alpe
Copy link
Contributor Author

alpe commented Jun 7, 2022

Panics are catched in #32. It may still make sense to limit resources

@alpe alpe added M Medium task, 1-3 days work state_breaking labels Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
M Medium task, 1-3 days work question Further information is requested Requires Information Requires more information. Specify from whom! state_breaking
Projects
None yet
Milestone
Tgrade - "Post Mainnet"
Development

No branches or pull requests
1 participant
@alpe